Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add kms_key_identifier arg for aws_pipes_pipe #41082

Merged
merged 1 commit into from
Jan 28, 2025
Merged

feat: Add kms_key_identifier arg for aws_pipes_pipe #41082

merged 1 commit into from
Jan 28, 2025

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jan 26, 2025

Description

This PR is to add the kms_key_identifier argument to the aws_pipes_pipe resource.

Relations

Closes #39288

References

Referred to CreatePipe for specs and wordings.

Output from Acceptance Testing

$ make testacc "TESTS=TestAccPipesPipe_basicSQS|TestAccPipesPipe_kmsKeyIdentifier" PKG=pipes
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/pipes/... -v -count 1 -parallel 20 -run='TestAccPipesPipe_basicSQS|TestAccPipesPipe_kmsKeyIdentifier'  -timeout 360m -vet=off
2025/01/25 23:29:01 Initializing Terraform AWS Provider...
=== RUN   TestAccPipesPipe_basicSQS
=== PAUSE TestAccPipesPipe_basicSQS
=== RUN   TestAccPipesPipe_kmsKeyIdentifier
=== PAUSE TestAccPipesPipe_kmsKeyIdentifier
=== CONT  TestAccPipesPipe_basicSQS
=== CONT  TestAccPipesPipe_kmsKeyIdentifier
--- PASS: TestAccPipesPipe_basicSQS (79.31s)
--- PASS: TestAccPipesPipe_kmsKeyIdentifier (140.03s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pipes      140.276s

$

@acwwat acwwat requested a review from a team as a code owner January 26, 2025 04:35
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/pipes Issues and PRs that pertain to the pipes service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jan 26, 2025
@acwwat acwwat force-pushed the f-aws_pipes_pipe-add_kms_key_identifier_arg branch from 3c79d7f to 595f1f4 Compare January 26, 2025 04:36
@acwwat acwwat force-pushed the f-aws_pipes_pipe-add_kms_key_identifier_arg branch from 595f1f4 to 03ad298 Compare January 26, 2025 04:54
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 27, 2025
@ewbankkit ewbankkit self-assigned this Jan 28, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 28, 2025
ewbankkit
ewbankkit approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccPipesPipe_basic\|TestAccPipesPipe_kmsKeyIdentifier' PKG=pipes ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/pipes/... -v -count 1 -parallel 3  -run=TestAccPipesPipe_basic\|TestAccPipesPipe_kmsKeyIdentifier -timeout 360m -vet=off
2025/01/28 07:34:21 Initializing Terraform AWS Provider...
=== RUN   TestAccPipesPipe_basicSQS
=== PAUSE TestAccPipesPipe_basicSQS
=== RUN   TestAccPipesPipe_kmsKeyIdentifier
=== PAUSE TestAccPipesPipe_kmsKeyIdentifier
=== CONT  TestAccPipesPipe_basicSQS
=== CONT  TestAccPipesPipe_kmsKeyIdentifier
--- PASS: TestAccPipesPipe_basicSQS (88.53s)
--- PASS: TestAccPipesPipe_kmsKeyIdentifier (153.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pipes	159.270s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 72c3e95 into hashicorp:main Jan 28, 2025
56 checks passed
@github-actions github-actions bot added this to the v5.85.0 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/pipes Issues and PRs that pertain to the pipes service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.85.0
Development

Successfully merging this pull request may close these issues.

Amazon EventBridge Pipes now supports CMKs
3 participants
@acwwat @ewbankkit @justinretzolk