Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sagemaker_endpoint_configuration - allow scaling endpoints to zero #40882

Merged
merged 3 commits into from
Jan 13, 2025
Merged

r/sagemaker_endpoint_configuration - allow scaling endpoints to zero #40882

merged 3 commits into from
Jan 13, 2025
+45 −7

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 12, 2025 •
edited
Loading

Description

Relations

Closes #40606

References

Output from Acceptance Testing

% make testacc TESTS=TestAccSageMakerEndpointConfiguration_productionVariantsManagedInstanceScaling PKG=sagemaker

--- PASS: TestAccSageMakerEndpointConfiguration_productionVariantsManagedInstanceScalingZero (26.61s)
--- PASS: TestAccSageMakerEndpointConfiguration_productionVariantsManagedInstanceScaling (30.29s)

@DrFaust92
allow scaling endpoints to zero
7523c32 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jan 12, 2025
@DrFaust92
changelog
ed43720 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 12, 2025
@DrFaust92 DrFaust92 marked this pull request as ready for review January 12, 2025 02:49
@DrFaust92 DrFaust92 requested a review from a team as a code owner January 12, 2025 02:49
@ewbankkit ewbankkit self-assigned this Jan 13, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 13, 2025
ewbankkit
ewbankkit approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerEndpointConfiguration_productionVariants\|TestAccSageMakerEndpointConfiguration_basic' PKG=sagemaker                 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMakerEndpointConfiguration_productionVariants\|TestAccSageMakerEndpointConfiguration_basic -timeout 360m -vet=off
2025/01/13 10:08:29 Initializing Terraform AWS Provider...
=== RUN   TestAccSageMakerEndpointConfiguration_basic
=== PAUSE TestAccSageMakerEndpointConfiguration_basic
=== RUN   TestAccSageMakerEndpointConfiguration_productionVariantsManagedInstanceScaling
=== PAUSE TestAccSageMakerEndpointConfiguration_productionVariantsManagedInstanceScaling
=== RUN   TestAccSageMakerEndpointConfiguration_productionVariantsManagedInstanceScalingZero
=== PAUSE TestAccSageMakerEndpointConfiguration_productionVariantsManagedInstanceScalingZero
=== CONT  TestAccSageMakerEndpointConfiguration_basic
=== CONT  TestAccSageMakerEndpointConfiguration_productionVariantsManagedInstanceScalingZero
=== CONT  TestAccSageMakerEndpointConfiguration_productionVariantsManagedInstanceScaling
--- PASS: TestAccSageMakerEndpointConfiguration_basic (25.78s)
--- PASS: TestAccSageMakerEndpointConfiguration_productionVariantsManagedInstanceScalingZero (26.58s)
--- PASS: TestAccSageMakerEndpointConfiguration_productionVariantsManagedInstanceScaling (29.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	35.025s

johnsonaj
johnsonaj approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 29912cc into hashicorp:main Jan 13, 2025
43 checks passed
@github-actions github-actions bot added this to the v5.84.0 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.84.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Sagemaker endpoint scaling to zero
3 participants
@DrFaust92 @ewbankkit @johnsonaj