r/aws_apigatewayv2: additional ConflictException retry logic
#40840
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
service/apigatewayv2
This change adds an additional step to the `apigatewayv2` service client retry logic to check for `ConflictException` error responses based solely on the message content. This is intended to address cases where the error is not serialized into the higher level `types.ConflictException` defined as the service package level (which the existing logic expects). Local testing of the configuration provided in the linked issue confirmed this additional logic prevents the intermittent failures observed during destruction of large numbers of routes in parallel. ```console % make testacc PKG=apigatewayv2 TESTS=TestAccAPIGatewayV2Route_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.3 test ./internal/service/apigatewayv2/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayV2Route_' -timeout 360m 2025/01/08 15:06:20 Initializing Terraform AWS Provider... --- PASS: TestAccAPIGatewayV2Route_disappears (17.18s) --- PASS: TestAccAPIGatewayV2Route_basic (18.81s) --- PASS: TestAccAPIGatewayV2Route_target (19.62s) --- PASS: TestAccAPIGatewayV2Route_model (19.76s) --- PASS: TestAccAPIGatewayV2Route_updateRouteKey (27.79s) --- PASS: TestAccAPIGatewayV2Route_requestParameters (36.06s) --- PASS: TestAccAPIGatewayV2Route_simpleAttributes (36.27s) --- PASS: TestAccAPIGatewayV2Route_authorizer (53.29s) --- PASS: TestAccAPIGatewayV2Route_jwtAuthorization (53.34s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2 59.735s ```
jar-b
force-pushed
the
b-apigatewayv2-client-retries
branch
from
c60c7cd to
d982ad6
Compare
jar-b
added
the
regression
|
This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
github-actions
bot
removed
the
prioritized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds an additional step to the
apigatewayv2service client retry logic to check forConflictExceptionerror responses based solely on the message content. This is intended to address cases where the error is not serialized into the higher leveltypes.ConflictExceptiondefined as the service package level (which the existing logic expects). Local testing of the configuration provided in the linked issue confirmed this additional logic prevents the intermittent failures observed during destruction of large numbers of routes in parallel.Relations
Closes #40575
References
*smithy.OperationErrorOutput from Acceptance Testing