Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support of valkey engine for elasticache user and usergroup #40764

Merged
merged 6 commits into from
Jan 6, 2025
Merged

support of valkey engine for elasticache user and usergroup #40764

merged 6 commits into from
Jan 6, 2025

Conversation

sasidhar-aws
Copy link
Contributor

Description

Adding support for Valkey engine in Elasticache user and usergroup resources.

Relations

Closes #40286

References

Output from Acceptance Testing

make testacc TESTS=TestAccElastiCacheUser_update_engine PKG=elasticache
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheUser_update_engine'  -timeout 360m
2025/01/03 10:22:55 Initializing Terraform AWS Provider...
=== RUN   TestAccElastiCacheUser_update_engine
=== PAUSE TestAccElastiCacheUser_update_engine
=== CONT  TestAccElastiCacheUser_update_engine
--- PASS: TestAccElastiCacheUser_update_engine (132.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	137.004s


make testacc TESTS=TestAccElastiCacheUserGroup_update PKG=elasticache  
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheUserGroup_update'  -timeout 360m
2025/01/03 10:53:57 Initializing Terraform AWS Provider...
=== RUN   TestAccElastiCacheUserGroup_update
=== PAUSE TestAccElastiCacheUserGroup_update
=== CONT  TestAccElastiCacheUserGroup_update
--- PASS: TestAccElastiCacheUserGroup_update (505.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	511.033s

@sasidhar-aws sasidhar-aws requested a review from a team as a code owner January 3, 2025 18:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elasticache Issues and PRs that pertain to the elasticache service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jan 3, 2025
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 6, 2025
@ewbankkit ewbankkit self-assigned this Jan 6, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 6, 2025
@ewbankkit
Merge branch 'main' into HEAD
a483261
@ewbankkit
Tweak CHANGELOG entries.
ae392f5
@ewbankkit
Cosmetics.
1375c22
@ewbankkit
Fix 'testAccUserGroupConfig_engineValkey': 'operation error ElastiCac…
a5ee591 
…he: ModifyUser, https response error StatusCode: 400, RequestID: a7c03416-8677-419b-a6fa-274072ab6636, InvalidParameterCombination: The user is associated to Redis user group tf-acc-6578360618284093375, please modify the engine of the user group before modifying the engine of the user'.
ewbankkit
ewbankkit approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccElastiCacheUserGroup_\|TestAccElastiCacheUser_' PKG=elasticache ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/elasticache/... -v -count 1 -parallel 3  -run=TestAccElastiCacheUserGroup_\|TestAccElastiCacheUser_ -timeout 360m
2025/01/06 10:58:23 Initializing Terraform AWS Provider...
=== RUN   TestAccElastiCacheUserGroup_basic
=== PAUSE TestAccElastiCacheUserGroup_basic
=== RUN   TestAccElastiCacheUserGroup_update
=== PAUSE TestAccElastiCacheUserGroup_update
=== RUN   TestAccElastiCacheUserGroup_tags
=== PAUSE TestAccElastiCacheUserGroup_tags
=== RUN   TestAccElastiCacheUserGroup_disappears
=== PAUSE TestAccElastiCacheUserGroup_disappears
=== RUN   TestAccElastiCacheUser_basic
=== PAUSE TestAccElastiCacheUser_basic
=== RUN   TestAccElastiCacheUser_passwordAuthMode
=== PAUSE TestAccElastiCacheUser_passwordAuthMode
=== RUN   TestAccElastiCacheUser_iamAuthMode
=== PAUSE TestAccElastiCacheUser_iamAuthMode
=== RUN   TestAccElastiCacheUser_update
=== PAUSE TestAccElastiCacheUser_update
=== RUN   TestAccElastiCacheUser_updateEngine
=== PAUSE TestAccElastiCacheUser_updateEngine
=== RUN   TestAccElastiCacheUser_updatePasswordAuthMode
=== PAUSE TestAccElastiCacheUser_updatePasswordAuthMode
=== RUN   TestAccElastiCacheUser_tags
=== PAUSE TestAccElastiCacheUser_tags
=== RUN   TestAccElastiCacheUser_disappears
=== PAUSE TestAccElastiCacheUser_disappears
=== RUN   TestAccElastiCacheUser_oobModify
=== PAUSE TestAccElastiCacheUser_oobModify
=== CONT  TestAccElastiCacheUserGroup_basic
=== CONT  TestAccElastiCacheUser_update
=== CONT  TestAccElastiCacheUser_basic
--- PASS: TestAccElastiCacheUser_basic (48.36s)
=== CONT  TestAccElastiCacheUser_tags
--- PASS: TestAccElastiCacheUser_tags (61.35s)
=== CONT  TestAccElastiCacheUser_oobModify
--- PASS: TestAccElastiCacheUser_update (111.26s)
=== CONT  TestAccElastiCacheUser_disappears
--- PASS: TestAccElastiCacheUserGroup_basic (172.18s)
=== CONT  TestAccElastiCacheUser_updatePasswordAuthMode
--- PASS: TestAccElastiCacheUser_oobModify (181.13s)
=== CONT  TestAccElastiCacheUser_updateEngine
--- PASS: TestAccElastiCacheUser_disappears (225.74s)
=== CONT  TestAccElastiCacheUser_iamAuthMode
--- PASS: TestAccElastiCacheUser_updatePasswordAuthMode (179.23s)
=== CONT  TestAccElastiCacheUser_passwordAuthMode
--- PASS: TestAccElastiCacheUser_updateEngine (65.38s)
=== CONT  TestAccElastiCacheUserGroup_tags
--- PASS: TestAccElastiCacheUser_iamAuthMode (78.14s)
=== CONT  TestAccElastiCacheUserGroup_disappears
--- PASS: TestAccElastiCacheUser_passwordAuthMode (68.06s)
=== CONT  TestAccElastiCacheUserGroup_update
--- PASS: TestAccElastiCacheUserGroup_tags (177.57s)
--- PASS: TestAccElastiCacheUserGroup_disappears (180.04s)
--- PASS: TestAccElastiCacheUserGroup_update (342.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	784.542s

nam054
nam054 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@nam054 nam054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@sasidhar-aws Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1b77fb6 into hashicorp:main Jan 6, 2025
41 of 42 checks passed
@github-actions github-actions bot added this to the v5.83.0 milestone Jan 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nam054 nam054 nam054 approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.83.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Addition of Valkey to aws_elasticache_user and aws_elasticache_user_group
3 participants
@sasidhar-aws @ewbankkit @nam054