Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add CloudTrail Event Data Store suspend ingestion #40607

Merged
merged 10 commits into from
Jan 27, 2025
Merged

feat: Add CloudTrail Event Data Store suspend ingestion #40607

merged 10 commits into from
Jan 27, 2025
+251 −30

Conversation

jsakama
Copy link
Contributor

@jsakama jsakama commented Dec 18, 2024 •
edited
Loading

Relations

This PR is add the suspend argument to aws_cloudtrail_event_data_store resource.

Closes #34910

References

AWS API Documentation: StopEventDataStoreIngestion and StartEventDataStoreIngestion.

Output from Acceptance Testing

$ make testacc TESTS=TestAccCloudTrailEventDataStore_suspend PKG=cloudtrail
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/cloudtrail/... -v -count 1 -parallel 20 -run='TestAccCloudTrailEventDataStore_suspend'  -timeout 360m
2025/01/07 15:50:58 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudTrailEventDataStore_suspend
=== PAUSE TestAccCloudTrailEventDataStore_suspend
=== CONT  TestAccCloudTrailEventDataStore_suspend
--- PASS: TestAccCloudTrailEventDataStore_suspend (30.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail 35.895s

@jsakama jsakama requested a review from a team as a code owner December 18, 2024 01:47
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. needs-triage Waiting for first response or review from a maintainer. labels Dec 18, 2024
@jsakama jsakama marked this pull request as draft December 18, 2024 01:49
@jsakama jsakama changed the title feat(ingestion-suspend): add suspend ingestion feat: Add CloudTrail Event Data Store suspend ingestion Dec 18, 2024
github-actions[bot]
github-actions bot reviewed Dec 18, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jsakama 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 6, 2025
@jsakama jsakama marked this pull request as ready for review January 7, 2025 06:58
ewbankkit
ewbankkit previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudTrailEventDataStore_' PKG=cloudtrail ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/cloudtrail/... -v -count 1 -parallel 3  -run=TestAccCloudTrailEventDataStore_ -timeout 360m -vet=off
2025/01/21 16:13:34 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudTrailEventDataStore_basic
=== PAUSE TestAccCloudTrailEventDataStore_basic
=== RUN   TestAccCloudTrailEventDataStore_billingMode
=== PAUSE TestAccCloudTrailEventDataStore_billingMode
=== RUN   TestAccCloudTrailEventDataStore_suspend
=== PAUSE TestAccCloudTrailEventDataStore_suspend
=== RUN   TestAccCloudTrailEventDataStore_kmsKeyId
=== PAUSE TestAccCloudTrailEventDataStore_kmsKeyId
=== RUN   TestAccCloudTrailEventDataStore_disappears
=== PAUSE TestAccCloudTrailEventDataStore_disappears
=== RUN   TestAccCloudTrailEventDataStore_tags
=== PAUSE TestAccCloudTrailEventDataStore_tags
=== RUN   TestAccCloudTrailEventDataStore_options
=== PAUSE TestAccCloudTrailEventDataStore_options
=== RUN   TestAccCloudTrailEventDataStore_advancedEventSelector
=== PAUSE TestAccCloudTrailEventDataStore_advancedEventSelector
=== CONT  TestAccCloudTrailEventDataStore_basic
=== CONT  TestAccCloudTrailEventDataStore_disappears
=== CONT  TestAccCloudTrailEventDataStore_suspend
--- PASS: TestAccCloudTrailEventDataStore_disappears (13.04s)
=== CONT  TestAccCloudTrailEventDataStore_kmsKeyId
--- PASS: TestAccCloudTrailEventDataStore_basic (15.15s)
=== CONT  TestAccCloudTrailEventDataStore_options
    event_data_store_test.go:282: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccCloudTrailEventDataStore_options (0.31s)
=== CONT  TestAccCloudTrailEventDataStore_advancedEventSelector
--- PASS: TestAccCloudTrailEventDataStore_advancedEventSelector (14.04s)
=== CONT  TestAccCloudTrailEventDataStore_tags
--- PASS: TestAccCloudTrailEventDataStore_kmsKeyId (20.07s)
=== CONT  TestAccCloudTrailEventDataStore_billingMode
--- PASS: TestAccCloudTrailEventDataStore_suspend (39.91s)
--- PASS: TestAccCloudTrailEventDataStore_billingMode (21.64s)
--- PASS: TestAccCloudTrailEventDataStore_tags (29.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail	64.315s

@ewbankkit @jar-b
Update website/docs/r/cloudtrail_event_data_store.html.markdown
fb29660 
Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
@ewbankkit
Copy link
Contributor

@jsakama Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b4203d2 into hashicorp:main Jan 27, 2025
43 checks passed
@github-actions github-actions bot added this to the v5.85.0 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jar-b jar-b jar-b approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.85.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Suspend CloudTrail Event Data Store data ingestion
4 participants
@jsakama @ewbankkit @jar-b @justinretzolk