Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Raft.LeaderCh() return a new channel for each invocation #427

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make Raft.LeaderCh() return a new channel for each invocation #427

wants to merge 3 commits into from

Conversation

Jille
Copy link
Contributor

@Jille Jille commented Sep 8, 2020

.. and immediately send the current leadership state over the channel.

This way it can be used by multiple pieces of code with disrupting another.

Sending the value immediately avoids strange race conditions when RaftState gets updated at a slightly different moment.

fixes #426

@Jille
Make Raft.LeaderCh() return a new channel for each invocation
bee73bc 
.. and immediately send the current leadership state over the channel.

This way it can be used by multiple pieces of code with disrupting another.

Sending the value immediately avoids strange race conditions when RaftState gets updated at a slightly different moment.

fixes hashicorp#426
@hashicorp-cla
Copy link

hashicorp-cla commented Sep 8, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Jille added 2 commits September 8, 2020 21:28
@Jille
Fix tests after changes in bee73bc
079ba8b
@Jille
Small bugfix to bee73bc
40ca28e 
I forgot to update r.leaderChLastMessage
Jille added a commit to Jille/raft-grpc-leader-rpc that referenced this pull request Sep 9, 2020
@Jille
Use the new Raft.LeaderCh() to detect leadership
0261455 
This is available since hashicorp/raft#427 but the code is backwards compatible and detects whether your version of Raft includes it.
Jille added a commit to Jille/raft-grpc-leader-rpc that referenced this pull request Sep 9, 2020
@Jille
Use the new Raft.LeaderCh() to detect leadership
a4b7b2a 
This is available since hashicorp/raft#427 but the code is backwards compatible and detects whether your version of Raft includes it.
Jille added a commit to Jille/raft-grpc-leader-rpc that referenced this pull request Sep 9, 2020
@Jille
Use the new Raft.LeaderCh() to detect leadership
075c8f3 
This is available since hashicorp/raft#427 but the code is backwards compatible and detects whether your version of Raft includes it.
@stale
Copy link

stale bot commented Nov 7, 2020

Hey there,
We wanted to check in on this request since it has been inactive for at least 90 days.
Have you reviewed the latest godocs?
If you think this is still an important issue in the latest version of the Raft library or
its documentation please feel let us know and we'll keep it open for investigation.
If there is still no activity on this request in 30 days, we will go ahead and close it.
Thank you!

@stale stale bot added the waiting-reply label Nov 7, 2020
@Jille
Copy link
Contributor Author

Jille commented Nov 7, 2020

still relevant

@stale stale bot removed the waiting-reply label Nov 7, 2020
@Jille Jille mentioned this pull request Jan 5, 2021
Closed
@stale
Copy link

stale bot commented Jan 10, 2021

Hey there,
We wanted to check in on this request since it has been inactive for at least 90 days.
Have you reviewed the latest godocs?
If you think this is still an important issue in the latest version of the Raft library or
its documentation please feel let us know and we'll keep it open for investigation.
If there is still no activity on this request in 30 days, we will go ahead and close it.
Thank you!

@stale stale bot added the waiting-reply label Jan 10, 2021
@Jille
Copy link
Contributor Author

Jille commented Jan 10, 2021

still relevant, discussion in #426 got some traction the other day actually

@stale stale bot removed the waiting-reply label Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
thinking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No good way to watch leadership
3 participants
@Jille @hashicorp-cla @schristoff