Fixed Crypto import and added requirements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2019 17:10
haseebT
requested changes
Sep 18, 2019
There was a problem hiding this comment.
Hi Tristan,
Can you change your requirements.txt file to require pycryptodome and not pycrypto. Pycryptodome is a fork of PyCrypto and brings several enhancements to it, one being support for AES-GCM. All of its modules are under the Crypto package. Currently the script requires the pycryptodomex package which is why Cryptodome.Cipher is imported.
https://pypi.org/project/pycryptodome/
Your other commit is fine.
|
Hi, you need to change this too in mremoteng_decrypt.py and maybe add to README.md to launch pip install pycryptodome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.