Support Float type fields in DBReader #28
Conversation
|
Thanks Simon, will review at earliest!
|
|
Do you need an issue against this as well? |
| dis.readFully(b) | ||
| val fld = new Text() | ||
| fld.clear() | ||
| fld.set(new String(b)) |
There was a problem hiding this comment.
- do you need new String(b) here, i am not in front of a IDE but i thought there is a set method on text which accepts a byte array and start/ end positions?
- do you need clear on a newly allocated text object?
|
@simonellistonball , no need for an issue against this.. as soon as the code review is done and the test is in place, i can do a final pass and pull the patch in. |
Replaced test data with generated data to avoid license problem
Replaced test data with generated data to avoid license problem
This added simple support for the Float type in DBF files, which exists in some shapefile sources.
Test to come, when I dig up appropriately licensed data.