Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Tracing Support for HAProxy in Instana #2782

Open
vishnusemirc opened this issue Nov 19, 2024 · 5 comments
Open

Integrating Tracing Support for HAProxy in Instana #2782

vishnusemirc opened this issue Nov 19, 2024 · 5 comments
Labels
type: feature This issue describes a feature request / wishlist.

Comments

@vishnusemirc
Copy link

Your Feature Request

Instana is planning to add tracing support to HAProxy and needs to confirm a few details before proceeding. We've seen in Git Hub that HAProxy is planning to integrate the OpenTelemetry (OTEL) support, so we'd like to confirm the current status of OTEL support.
Also we would like to understand if there's an opportunity for us to contribute our Instana tracing plugin, which is based on OpenTracing, while ensuring long-term support.
Could you please confirm which method would be preferable for you—OpenTracing or OpenTelemetry?
If the OTEL support is feasible, we'd like to know if we can contribute specific code changes, such as dropping Instana headers, adding resource attributes, infrastructure linking, OTel metrics.

Your feedback will help us to plan the best way to proceed.

What are you trying to do?

Planning to add tracing support to HAProxy in Instana.

Output of haproxy -vv

NA
@vishnusemirc vishnusemirc added the type: feature This issue describes a feature request / wishlist. label Nov 19, 2024
@vishnusemirc
Copy link
Author

Hi @capflam,

Could you please help me on this?
TIA.

@capflam
Copy link
Member

capflam commented Nov 22, 2024

I don't know how Instana works, so it is hard for me to fully answer you.

About the OpenTracing support. Because the project is fully dead since now 2 years, the HAProxy add-on will be removed, may be after a deprecation period, but independently on OpenTelemetry support. An OpenTelemetry add-on will be welcome if anyone is willing to work on it and to maintain it. I'm tempted to say that if it was not implemented in 2 years to replace the Opentracing add-on, it means there is not a strong traction from the community. But I may be wrong.

Technically speaking, you must base your work on OpenTelemetry, definitely. But I don't know what implies an Instana tracing plugin. You must elaborate. But first of all, you should land the subject on the mailing-list because add-ons are only added if there are someone ready to use it. It is useless to have a long list of unused add-on.

@capflam
Copy link
Member

capflam commented Nov 22, 2024

Of course, you must also check it is compatible with the HAproxy licence. You may check CONTRIBUTING file.

@zaga00
Copy link
Contributor

zaga00 commented Nov 22, 2024

The OpenTelemetry filter is under development and will be very similar to the current OpenTracing filter. However, it is not that simple (as it was not simple for OpenTracing either) because first I have to make a C wrapper for opentelemetry-cpp API. It will probably be usable in the 3.2 version of HAProxy.

Also, even though OpenTelemetry has been in development for several years, it has not been a complete and stable C++ API for a long time, so I waited for it to finish.

Regarding Instana, never worked with it, but I would repeat what @capflam wrote: "base it on OpenTelemetry".

haproxy-mirror pushed a commit that referenced this issue Nov 22, 2024
Miroslav mentioned below that he's currently working on an OpenTelemetry
replacement for the OpenTracing filter since OpenTracing itself is no
longer maintained nor supported:

  #2782 (comment)

Given that he aims for 3.2, let's already settle on an upcoming deprecation
of the filter for 3.3 with a removal for 3.5. This will leave time to finish
the development and permit users to switch smoothly. At this point no warning
is emitted (since the users have no alternative) but better mention this plan
in the doc to make them aware of future changes.
@vishnusemirc
Copy link
Author

vishnusemirc commented Nov 25, 2024

@zaga00 and @capflam,

Thanks for the update.

Could you please confirm the roadmap for the upcoming HAProxy version 3.2, includes OTEL support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature This issue describes a feature request / wishlist.
Projects
None yet
Development

No branches or pull requests

3 participants