Remove racy check that relies on mtime changing between writes.

haiya512 · Jan 14, 2017 · b5d7ab9 · b5d7ab9
1 parent f9030f0
commit b5d7ab9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/NEWS b/NEWS
@@ -1,5 +1,10 @@
 0.16.3	UNRELEASED
 
+ TEST FIXES
+
+  * Remove racy check that relies on clock time changing between writes.
+   (Jelmer Vernooij)
+
 0.16.2	2016-01-14
 
  IMPROVEMENTS

diff --git a/dulwich/tests/test_index.py b/dulwich/tests/test_index.py
@@ -405,7 +405,8 @@ def test_norewrite(self):
             build_index_from_tree(repo.path, repo.index_path(),
                                   repo.object_store, tree.id)
             sync()
-            self.assertNotEqual(mtime, os.stat(filea_path).st_mtime)
+            with open(filea_path, 'rb') as fh:
+                self.assertEqual(b'file a', fh.read())
 
 
     @skipIf(not getattr(os, 'symlink', None), 'Requires symlink support')