#13 Adding Householder transformations and the QR decomposition #20
Conversation
breezko
commented
Oct 4, 2020
breezko
commented
- Fixing Imports
- Following pytest name conventions
|
The pipeline check is weird, I can't change subject etc ;) |
|
It should respect the format from here: https://github.com/commitizen/cz-cli (I think here is better: https://commitlint.io/) |
|
So like this @gmuraru : If that's correct I'd amend my commit asap. |
|
I don't think that is going to work. |
My pervious message was the resut of commitlint.io I used as subject "feature" |
|
Ahh...apologies...I did not see the |
|
It seems the problem is the following: There should be a subject and a type |
Alright, as soon as I'm home I'll fix the commit message :) |
Languages/Python/nice_implementations/src/householder/householder.py
Outdated
Show resolved
Hide resolved
Languages/Python/nice_implementations/src/householder/householder.py
Outdated
Show resolved
Hide resolved
…osition & Fixing imports
| @@ -1,4 +1,4 @@ | |||
| from src.trie.trie import Trie | |||
| from ...src.trie.trie import Trie | |||
There was a problem hiding this comment.
MAYBE: Could you leave it as it was before - the tests are supposed to be run from the root of the project
| """ Test small 3x3 example from the Wikipedia page on QR decomposition """ | ||
| A = np.array([[12, -51, 4], [6, 167, -68], [-4, 24, -41]]) | ||
| Q, R = qr(A) | ||
| print("A=", A, "Q=", Q, "R=", R, sep="\n\n", file=open("Small QR example.txt", "w")) |
| """ Test small 3x3 example from the Wikipedia page on QR decomposition """ | ||
| A = np.array([[12, -51, 4], [6, 167, -68], [-4, 24, -41]]) | ||
| Q, R = qr(A) | ||
| print("A=", A, "Q=", Q, "R=", R, sep="\n\n", file=open("Small QR example.txt", "w")) |
| """ | ||
| A = gaussian_matrix(m, n) | ||
| Q, R = qr(A) | ||
| for e in qr_errors(A, Q, R): |
There was a problem hiding this comment.
SHOULD: Use np.all_close and remove the qr_errors function
|
@breezko are you still working on this? |
