defer reactor import in twisted.web.xmlrpc

glyph · Sep 16, 2020 · 0837c8d · 0837c8d
1 parent 1464533
commit 0837c8d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/twisted/web/newsfragments/9931.bugfix b/src/twisted/web/newsfragments/9931.bugfix
@@ -0,0 +1 @@
+defer reactor import in twisted.web.xmlrpc
diff --git a/src/twisted/web/xmlrpc.py b/src/twisted/web/xmlrpc.py
@@ -22,7 +22,7 @@
 
 # Sibling Imports
 from twisted.web import resource, server, http
-from twisted.internet import defer, protocol, reactor, error
+from twisted.internet import defer, protocol, error
 from twisted.python import reflect, failure
 from twisted.logger import Logger
 
@@ -527,7 +527,7 @@ def __init__(
         allowNone=False,
         useDateTime=False,
         connectTimeout=30.0,
-        reactor=reactor,
+        reactor=None,
     ):
         """
         @param url: The URL to which to post method calls.  Calls will be made
@@ -537,6 +537,9 @@ def __init__(
         @type url: L{bytes}
 
         """
+        if reactor is None:
+            from twisted.internet import reactor
+
         scheme, netloc, path, params, query, fragment = urlparse(url)
         netlocParts = netloc.split(b"@")
         if len(netlocParts) == 2: