Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start compiling with -Wsign-compare #1840

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
+519 −235
Open

Start compiling with -Wsign-compare #1840

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f1f5978
Start compiling with `-Wsign-compare`
pks-t Nov 28, 2024
4b1b789
git-compat-util: introduce macros to disable "-Wsign-compare" warnings
pks-t Nov 28, 2024
9374c60
compat/regex: explicitly ignore "-Wsign-compare" warnings
pks-t Nov 28, 2024
5e171b5
compat/win32: fix -Wsign-compare warning in "wWinMain()"
pks-t Nov 29, 2024
05f2d3b
global: mark code units that generate warnings with `-Wsign-compare`
pks-t Nov 28, 2024
dd11822
config.mak.dev: drop `-Wno-sign-compare`
pks-t Nov 28, 2024
14623c9
diff.h: fix index used to loop through unsigned integer
pks-t Nov 28, 2024
8647bcb
csum-file: fix -Wsign-compare warning on 32-bit platform
gitster Dec 4, 2024
ea870e7
pkt-line: fix -Wsign-compare warning on 32 bit platform
pks-t Dec 6, 2024
482020a
global: trivial conversions to fix `-Wsign-compare` warnings
pks-t Nov 28, 2024
9b39393
daemon: fix loops that have mismatching integer types
pks-t Nov 28, 2024
20b4332
daemon: fix type of `max_connections`
pks-t Nov 28, 2024
3708125
gpg-interface: address -Wsign-comparison warnings
pks-t Dec 2, 2024
74710de
builtin/blame: fix type of `length` variable when emitting object ID
pks-t Dec 2, 2024
7527b49
builtin/patch-id: fix type of `get_one_patchid()`
pks-t Dec 2, 2024
2b3c65b
scalar: address -Wsign-compare warnings
pks-t Dec 2, 2024
aac9938
t/helper: don't depend on implicit wraparound
pks-t Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
csum-file: fix -Wsign-compare warning on 32-bit platform 
On 32-bit platforms, ssize_t may be "int" while size_t may be
"unsigned int".  At times we compare the number of bytes we read
stored in a ssize_t variable with "unsigned int", but that is done
after we check that we did not get an error return (which is
negative---and that is the whole reason why we used ssize_t and not
size_t), so these comparisons are safe.

But compilers may not realize that.  Cast these to size_t to work
around the false positives.  On platforms with size_t/ssize_t wider
than a normal int, this won't be an issue.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
  • Loading branch information
@gitster @pks-t
gitster authored and pks-t committed Dec 6, 2024
commit 8647bcb017eac1d1520a1264910896dbf0b37722
3 changes: 1 addition & 2 deletions csum-file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
*/

#define USE_THE_REPOSITORY_VARIABLE
#define DISABLE_SIGN_COMPARE_WARNINGS

#include "git-compat-util.h"
#include "progress.h"
Expand All @@ -24,7 +23,7 @@ static void verify_buffer_or_die(struct hashfile *f,

if (ret < 0)
die_errno("%s: sha1 file read error", f->name);
if (ret != count)
if ((size_t)ret != count)
die("%s: sha1 file truncated", f->name);
if (memcmp(buf, f->check_buffer, count))
die("sha1 file '%s' validation error", f->name);
Expand Down