archive-zip: Added macros, also corrected payload size #1775
Conversation
|
There are issues in commit b3fd75f: |
shubhamessier
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
What's the next step to my contribution, I hope it works just fine. |
There was a problem hiding this comment.
@shubhamessier are you interested in contributing this patch? If so, I encourage you to have a look at https://github.blog/2022-06-30-write-better-commits-build-better-projects/ to improve it, in particular with a strong focus on this part:
| What you’re doing | Why you’re doing it | |
|---|---|---|
| High-level (strategic) | Intent (what does this accomplish?) | Context (why does the code do what it does now?) |
| Low-level (tactical) | Implementation (what did you do to accomplish your goal?) | Justification (why is this change being made?) |
Also, the build seems to fail, have you test-compiled this in your local setup? Does it compile there?
|
@shubhamessier are you still interested in this PR? |
|
@dscho yes sure, just let me run the checks locally again to fix those build fails. |
No description provided.