trim header value when space or tab

ggjulio · Oct 27, 2021 · 3727f6f · 3727f6f
1 parent 72c7301
commit 3727f6f
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 3 deletions.
diff --git a/includes/ft/utility.hpp b/includes/ft/utility.hpp
@@ -28,6 +28,9 @@ void						lowerStringInPlace(std::string& s);
 void						upperStringInPlace(std::string& s);
 bool						isInteger(std::string& s);
 std::string					getDate();
+std::string					trim(const std::string& str,
+								 const std::string& whitespace = " \t");
+
 
 /// return the number of consecutives same elements in two paths.
 bool	pathsComponentsAreEqual(const filesystem::path& one, const filesystem::path& two, size_t& nSameComp);

diff --git a/src/ft/utility.cpp b/src/ft/utility.cpp
@@ -62,6 +62,20 @@ std::string getDate()
 	return date;
 }
 
+std::string trim(const std::string& str,
+                 const std::string& whitespace)
+{
+    const size_t strBegin = str.find_first_not_of(whitespace);
+    if (strBegin == std::string::npos)
+        return "";
+
+    const size_t strEnd = str.find_last_not_of(whitespace);
+    const size_t strRange = strEnd - strBegin + 1;
+
+    return str.substr(strBegin, strRange);
+}
+
+
 // Return true if both paths are equal, else false and tell how many comp are the same by variable nSameComp
 bool	pathsComponentsAreEqual(const filesystem::path& one, const filesystem::path& two, size_t& nSameComp)
 {

diff --git a/src/http/messageParser.cpp b/src/http/messageParser.cpp
@@ -130,7 +130,7 @@ namespace http
 						return;
 					}
 					if (!name.empty() && isValueField)
-						req.setHeader(name, value);
+						req.setHeader(name, ft::trim(value));
 					else if (name.empty())
 						areHeadersParsed = true;
 					name.clear();

diff --git a/tests/http_requests/chunked_post b/tests/http_requests/chunked_post
@@ -2,7 +2,7 @@ POST /test.php HTTP/1.1
 Host: localhost:83
 Date: Mon, 22 Mar 2004 11:15:03 GMT
 Content-Type: text/html
-Transfer-Encoding: chunked
+Transfer-Encoding: chunked 
 
 29
 <html><body><p>The file you requested is 

diff --git a/tests/http_requests/simple_get b/tests/http_requests/simple_get
@@ -3,7 +3,7 @@ User-Agent: PostmanRuntime/7.26.10
 Accept: */*
 Postman-Token: ec250329-5eb0-4d4b-8150-39f294b6aea2
 Host: dynamicdns.park-your-domain.com:8080
-Accept-Encoding: gzip, deflate, br
+Accept-Encoding: gzip, deflate, br  
 Connection: keep-alive
 Content-Length: 4
 Cookie: ASPSESSIONIDQADTQAQR=JNJLAIGBPIMBDAJPJNIFKIEK