Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #515
Hello, and Happy Christmas 🎄
This PR iterates on #2630 with the given feedback of not requiring the use of the
markdown
filter to execute nested shortcodes. Additionally, unlike the previous PR, nested nth invocation increments follows a more intuitive pattern.Before:
After:
Sanity check:
Code changes
ShortcodeInvocationCounter
has been addedmarkdown::shortcode::parser::Shortcode
struct now hasinner: Vec<Shortcode>
markdown::shortcode::parser::parse_for_shortcodes
function now also parses shortcode bodiesflatten
method tomarkdown::shortcode::parser::Shortcode
which renders the inner-shortcodes into the shortcode bodyrender
method onmarkdown::shortcode::parser::Shortcode
now callsflatten
next
branch?If the change is a new feature or adding to/changing an existing one:
Let me know what you think!