Fix Mempool LN functionality #2042
Conversation
🎉 Linting finished with no errors or warnings 🎉Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store. Please review the linting results below and make any necessary changes to your submission. Linting Results
Legend
|
|
Tested and ready to be merged. @knorrium thanks very much for bringing this to our attention 🙏. Are you good with this hotfix going live or is there an imminent https://github.com/mempool/mempool update you'd like to wait for? |
|
@nmfretz thanks for the quick turnaround. Please merge it so we can continue testing our upcoming release. I caught this while upgrading our instances and didn't see anything obvious in the release notes, but thankfully my RPi was still on the previous version where it worked :) |
|
Thanks @knorrium. Going live. |
| # Check if Lightning Node app is installed and export required variables if so | ||
| # The Lightning Node app is optional and not listed in the `required` field of the umbrel-app.yml file, so we need to do this for compatibility with umbrelOS >=1.3 where only exports of required apps are sourced. | ||
| installed_apps=$("${UMBREL_ROOT}/scripts/app" ls-installed) |
There was a problem hiding this comment.
@nmfretz I just pulled the merged changes and I still don't see the exported variables.
Trying to debug, when I run umbrel/scripts/app ls-installed I get This script requires "docker-compose" to be installed, so it looks like the check below is failing.
Were you able to test this locally?
There was a problem hiding this comment.
Hey, yes I tested this in production on both arm64 and x86.
You will not be able to successfully run umbrel/scripts/app ls-installed manually in umbrelOS 1.0+. This is a legacy umbrelOS 0.5 script; however, umbreld in umbrelOS 1.0+ will properly handle this when sourcing the exports.sh file and it will translate it to the proper function call.
I just pulled the merged changes and I still don't see the exported variables.
I can help troubleshoot. How did you end up updating the mempool app to this current version (3.0.1-hotfix)?
There was a problem hiding this comment.
@nmfretz I usually do the following:
- Clone
umbrel-appsto the home dir (often from our fork, let's call itmempool-umbrel-apps, where we make the changes to the app) - Remove the local app definition
rm -rf umbrel/app-stores/getumbrel-umbrel-apps-github-53f74447/mempool/ - Copy the app from the cloned repo
cp -R ~/mempool-umbrel-apps/mempool ~/umbrel/app-stores/getumbrel-umbrel-apps-github-53f74447/mempool - Update the app
umbreld client apps.update.mutate --appId mempool
Then I checked the running container:
sudo sudocker ps | grep backenddocker exec -it <container_id> /bin/bashexportcat mempool-config.json
There was a problem hiding this comment.
While writing this I realized that I accidentally ran apps.restart.mutate instead of apps.update.mutate 🤦
Now that I updated the app, I can see that the lightning tab is working again and I see the correct exports.
There was a problem hiding this comment.
Thanks @knorrium, that all looks good. And so if you check the env of the api container right now does it show the correct LND variables or are they missing there too?
sudo docker exec mempool_api_1 env
There was a problem hiding this comment.
Here is mempool running on my Pi 5 right now:
$ sudo docker exec mempool_api_1 env | grep LND
LND_REST_API_URL=https://10.21.21.9:8080
LND_TIMEOUT=120000
LND_TLS_CERT_PATH=/lnd/tls.cert
LND_MACAROON_PATH=/lnd/data/chain/bitcoin/mainnet/readonly.macaroon
There was a problem hiding this comment.
@nmfretz just checked the env like that and I can confirm it's correct 🎉
Thanks again!
There was a problem hiding this comment.
While writing this I realized that I accidentally ran apps.restart.mutate instead of apps.update.mutate 🤦
Now that I updated the app, I can see that the lightning tab is working again and I see the correct exports.
Whoops, sorry I missed this when responding. Haha, no worries at all. Glad it's sorted. Excited for the next release!
This PR fixes an issue where in umbrelOS 1.3, optional Lightning Node app environment variables were not sourced for the mempool app.
Closes #2041