Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Deduplicate yarn.lock #14968

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nwalters512
Copy link

I'm splitting this out of #14967 since it was getting a little out of hand in that other PR.

Tests are currently failing, seemingly related to ampproject/remapping#193. It seems like this may only have been fixed in vitest v2? So that might be a blocker for these changes.

There's another strange failure in the packages/browser test:

        FAIL  test/eventbuilder.test.ts > extractMessage > should extract message from a WebAssembly.Exception object
       AssertionError: expected 'No error message' to be 'wasm exception' // Object.is equality
       
       - Expected
       + Received
       
       - wasm exception
       + No error message
       
        ❯ test/eventbuilder.test.ts:188:21
           186| 
           187|     const message = extractMessage(wasmException);
           188|     expect(message).toBe('wasm exception');
              |                     ^
           189|   });
           190| 

However, this also fails for me on the develop branch, so this may not be related to these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant