feat(core)!: Remove transactionContext from samplingContext
#14904
+1
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
force-pushed
the
sig/remove-transactionContext
branch
from
b4c814e to
8b83423
Compare
Lms24
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Good catch! Looks like we actually wanted to do this already in v8 but somehow forgot to remove it 🤔
let's add a ! to the PR title since this is still a breaking change
s1gr1d
changed the title
transactionContext from samplingContexttransactionContext from samplingContext
size-limit report 📦
|
AbhiPrasad
approved these changes
Jan 3, 2025
s1gr1d
force-pushed
the
sig/remove-transactionContext
branch
from
8b83423 to
29808e1
Compare
# Conflicts: # packages/opentelemetry/src/sampler.ts # packages/opentelemetry/test/trace.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
transactionContextas it only includes duplicated data.