fix(core): Restore previously active span when passing a custom scope to startSpanManual
#14901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #14900 and proposes active span restoration when passing a custom scope to
startSpanManual
. This is unfortunately a bit trickier than forstartSpan
because there are two ways how users can end a span:span.end()
finish
function passed to thestartSpanManual
callbackWith the changes in this PR, this two ways of ending a span would diverge in behaviour:
The alternative to the proposed change would be to monkey-patch
span.end()
to always restore the active span on custom scopes. Can also change the PR to do this if reviewers prefer it.