chore: Adjust grammer and formatting of migration doc #14890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
mydea and
Lms24
and removed request for
a team
Lms24
approved these changes
Jan 2, 2025
|
|
||
| ### Uncategorized (TODO) | ||
|
|
||
| TODO | ||
|
|
||
| ## 3. Package Removals | ||
|
|
||
| As part of an architectural cleanup we deprecated the following packages: | ||
| As part of an architectural cleanup, we deprecated the following packages: |
There was a problem hiding this comment.
l: Once v9 ships, we won't publish utils and types anymore, right?
Suggested change
| As part of an architectural cleanup, we deprecated the following packages: | |
| As part of an architectural cleanup, we deprecated and stopped publishing the following packages: |
Comment on lines
+173
to
+190
|
|
||
| These options should now be set as follows: | ||
|
|
||
| ```js | ||
| import * as Sentry from '@sentry/vue'; | ||
|
|
||
| Sentry.init({ | ||
| integrations: [ | ||
| Sentry.vueIntegration({ | ||
| tracingOptions: { | ||
| trackComponents: true, | ||
| timeout: 1000, | ||
| hooks: ['mount', 'update', 'unmount'], | ||
| }, | ||
| }), | ||
| ], | ||
| }); | ||
| ``` |
There was a problem hiding this comment.
l: should this not stay indented as it belongs to the bullet point above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes made based on trying to use the migration doc.