Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Arbitrary File Deletion abuse via Object Injection #3874

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Avoid Arbitrary File Deletion abuse via Object Injection #3874

wants to merge 1 commit into from
+2 −2

Conversation

mcdruid
Copy link

@mcdruid mcdruid commented Dec 3, 2024

As discussed with @rhukster this simple change should avoid \Grav\Framework\Cache\Adapter\FileCache::__destruct being abused via Object Injection to achieve Arbitrary File Deletion.

I've used strpos rather than str_starts_with as it looks like Grav supports PHP 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcdruid