net-misc/seafile & net-misc/seafile-client: bump to version 9.0.11 #40268
Conversation
Pull Request assignmentSubmitter: @clan net-misc/seafile: @gentoo/proxy-maint (maintainer needed) Linked bugsBugs linked: 926674 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
Pull request CI reportReport generated at: 2025-01-23 11:50 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| KEYWORDS="~amd64 ~x86" | ||
| REQUIRED_USE="${PYTHON_REQUIRED_USE}" | ||
|
|
||
| RDEPEND="${PYTHON_DEPS} |
There was a problem hiding this comment.
argon2 required since 9.0.10
| RDEPEND="${PYTHON_DEPS} | |
| RDEPEND="${PYTHON_DEPS} | |
| app-crypt/argon2 |
| dev-qt/qtcore:5 | ||
| dev-qt/qtdbus:5 | ||
| dev-qt/qtgui:5 | ||
| dev-qt/qtnetwork:5 | ||
| dev-qt/qtwidgets:5 |
There was a problem hiding this comment.
| dev-qt/qtcore:5 | |
| dev-qt/qtdbus:5 | |
| dev-qt/qtgui:5 | |
| dev-qt/qtnetwork:5 | |
| dev-qt/qtwidgets:5 | |
| dev-qt/qtbase:6[dbus,gui,network,ssl,widgets] | |
| dev-qt/qtwebengine:6[widgets] | |
| dev-qt/qt5compat:6 |
Why not switch to Qt6 ? Build is ok with -DQT_VERSION_MAJOR=6. Only test failed (still Qt5).
There was a problem hiding this comment.
it seems test failed for current stable version too, so I'll switch to qt6
There was a problem hiding this comment.
it seems test failed for current stable version too.
Maybe restrict it then.
There was a problem hiding this comment.
There is no such thing as a half-switch, anyway. The first version of your PR, switching only dev-qt/qtwebengine to SLOT 6, would not have worked at all.
How did you test that?
There was a problem hiding this comment.
sure, I did test and run it on my side, it did works IIRC. maybe my test PC have all the relevant packages installed, that's also the reason why argon2 is missed before (can be found by read git diff though); and thanks @PPN-SD 's point out, I understand more on the difference between qt5 & 6.
BTW, I'm new to qt, I know this is not the reason to made some silly mistakes.
There was a problem hiding this comment.
FYI: I did a test for the first version from a new chroot environment from stage3, "dev-qt/qt5compat:6" and "dev-qt/qttools:6[linguist]" are missing, qtbase6 is pulled in by qtwebengine, the unremoved qt5 dependencies are redunant.
Signed-off-by: Z. Liu <zhixu.liu@gmail.com>
| DEPEND="${RDEPEND} | ||
| test? ( dev-qt/qttest:5 )" | ||
| BDEPEND="dev-qt/linguist-tools:5" |
There was a problem hiding this comment.
| DEPEND="${RDEPEND} | |
| test? ( dev-qt/qttest:5 )" | |
| BDEPEND="dev-qt/linguist-tools:5" | |
| DEPEND="${RDEPEND}" | |
| BDEPEND="dev-qt/qttools:6[linguist]" |
|
|
||
| PATCHES=( | ||
| "${FILESDIR}/${PN}-9.0.11-select-qt6.patch" | ||
| "${FILESDIR}/${PN}-7.0.9-qt-5.15.patch" |
There was a problem hiding this comment.
| "${FILESDIR}/${PN}-7.0.9-qt-5.15.patch" |
Merged
Pull request CI reportReport generated at: 2025-01-23 16:00 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
1. qtwebengine is required if using Qt6 2. switch depend to Qt6 3. drop ~x86 KEYWORDS because of qtwebengine 4. remove USE="test", to be fixed Closes: https://bugs.gentoo.org/926674 Signed-off-by: Z. Liu <zhixu.liu@gmail.com>
Pull request CI reportReport generated at: 2025-01-23 17:55 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
if anyone else want to be the maintainer of this package, feel free to take it, thanks. BTW: test is removed in this PR, I can't make it success yet. |
for seafile-client: qtwebengine 6 is required if using qt6, see CMakeLists.txt
Please check all the boxes that apply:
Signed-off-byline to every commit in the pull request.pkgcheck scan --commits --netto check for issues with my commits.Please note that all boxes must be checked for the pull request to be merged.