Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine name/address + lat-lon search, plus add compact mode for widget-containers and other style tweaks. #2206

Merged
merged 8 commits into from
Jan 9, 2025

Conversation

sufyanAbbasi
Copy link
Collaborator

@sufyanAbbasi sufyanAbbasi commented Jan 7, 2025

  • Combines the name/address search with the lat-lon search.
  • Modifies the widget-container to have a compact mode to allow for more compact widgets like this.
  • Make sure dark mode works with all widget-containers.
  • Adds search to core widgets.
  • Deprecates "data_control" in favor or "search_control" (backwards compatible).

Demo: https://colab.research.google.com/drive/12NDbK_4rIDXtdWyetliJnTahFnVJ3fNg?usp=sharing

image
image
image
image

@sufyanAbbasi sufyanAbbasi requested a review from naschmitz January 7, 2025 23:59
Copy link
Collaborator

@naschmitz naschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! Thank you!

js/toolbar.ts Outdated Show resolved Hide resolved
@naschmitz naschmitz self-requested a review January 9, 2025 16:07
@sufyanAbbasi sufyanAbbasi merged commit 6fe2ab1 into gee-community:master Jan 9, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants