check whether autoplay actually should be restarted after hover #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
similar problem: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set
autoplayPauseOnHovertotruebutautoplaytofalse, on initialization, you end up with a carousel that is initially paused, but that starts autoplaying as soon as user mouse moves over it and out again.Here's a simple demo of the bug: http://jsfiddle.net/Aeon/AMtFn/1/
Open console and note that the carousel is initially paused, but once you mouse over it and mouse out, autoplay starts and
isAutoplayingis now true.Here's the demo after my fix: http://jsfiddle.net/Aeon/AMtFn/2/
Thanks for the great project, it's very nicely done!
PS. I wasn't sure what you use for minification, so I did not update the minified version of the code.