Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntlShape type mismatch between @formatjs/intl and react-intl #4491

Closed
cungminh2710 opened this issue Aug 15, 2024 · 2 comments
Closed

IntlShape type mismatch between @formatjs/intl and react-intl #4491

cungminh2710 opened this issue Aug 15, 2024 · 2 comments
Labels
bug Stale

Comments

@cungminh2710
Copy link
Contributor

Which package?

@formatjs/intl and react-intl

Describe the bug

When importing IntlShape from @formatjs/intl, I saw a type mismatch with the one in react-intl

  • react-intl

image

  • @formatjs/intl

image

Therefore, when passing the result of createIntl from @formatjs/intl to RawIntlProvider from react-intl, typescript 5.5.4 complaining about the type mismatch

image

Expected behavior

IntlShape type should be interchangable between @formatjs/intl and react-intl
@longlho
Copy link
Member

longlho commented Aug 22, 2024

yeah react-intl IntlShape has React-specific stuff and @formatjs/intl is React-agnostic

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 22, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@longlho @cungminh2710