-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set window type dialog for dialogs and transient windows #5376
base: master
Are you sure you want to change the base?
Conversation
Example screenshots? |
I don't know how to show this in a screenshot so I've recorded a video: https://youtu.be/embWmXLwOXk |
In Windows the Font Info dialog ceased to participate in tiling arrangement, which is the desired behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be fine
I don't think this one is ready yet.
|
I'll take a deeper look at it, but it doesn't seem to be easy thing. We are talking about very sensitive z-order / modality stuff which would need to be tested across many environments. X11 / Wayland / Windows / Gnome / Kde Plasma all have their peculiarities. |
Given our crimes with the Point Info dialog that may be a venal sin. |
So it sounds like any benefits don't currently outweigh the drawbacks. Do we have any evidence that there is relevant OS/stacks-specific behavior, or as far as we know now is this just a matter of some windows (e.g. the font info dialog) getting the wrong type_hint? And if the latter, is the issue that |
Now dialogs and transient windows have a correct window type so a window manager can better understand how to display them. (In my particular case, dwm checks window type and displays dialogs in floating mode)