Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set window type dialog for dialogs and transient windows #5376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

serhiyhelp
Copy link

Now dialogs and transient windows have a correct window type so a window manager can better understand how to display them. (In my particular case, dwm checks window type and displays dialogs in floating mode)

@jtanx
Copy link
Contributor

jtanx commented Feb 24, 2024

Example screenshots?

@serhiyhelp
Copy link
Author

I don't know how to show this in a screenshot so I've recorded a video: https://youtu.be/embWmXLwOXk

@iorsh
Copy link
Contributor

iorsh commented Mar 3, 2024

Tested in Gnome, KDE and windows:

In Gnome the Font Info dialog is non-modal, but is kept above all other windows, which is inconsistent with other window managers and probaly undesired.

On project:
ff_gnome_proj

On system:
ff_gnome_sys

@iorsh
Copy link
Contributor

iorsh commented Mar 3, 2024

In Windows the Font Info dialog ceased to participate in tiling arrangement, which is the desired behavior.

Copy link
Contributor

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be fine

@iorsh
Copy link
Contributor

iorsh commented Oct 6, 2024

I don't think this one is ready yet.

In Gnome the Font Info dialog is non-modal, but is kept above all other windows, which is inconsistent with other window managers and probably undesired.

@iorsh
Copy link
Contributor

iorsh commented Oct 6, 2024

I'll take a deeper look at it, but it doesn't seem to be easy thing. We are talking about very sensitive z-order / modality stuff which would need to be tested across many environments. X11 / Wayland / Windows / Gnome / Kde Plasma all have their peculiarities.

@skef
Copy link
Contributor

skef commented Oct 6, 2024

Given our crimes with the Point Info dialog that may be a venal sin.

@skef
Copy link
Contributor

skef commented Oct 6, 2024

So it sounds like any benefits don't currently outweigh the drawbacks.

Do we have any evidence that there is relevant OS/stacks-specific behavior, or as far as we know now is this just a matter of some windows (e.g. the font info dialog) getting the wrong type_hint? And if the latter, is the issue that is_dlg shouldn't imply modality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants