Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d3fc/datagrid packages point to nonexistent "types" location #2824

Open
brianblakely opened this issue Nov 4, 2024 · 1 comment
Open

d3fc/datagrid packages point to nonexistent "types" location #2824

brianblakely opened this issue Nov 4, 2024 · 1 comment
Labels
bug Concrete, reproducible bugs

Comments

@brianblakely
Copy link
Contributor

perspective/packages/perspective-viewer-d3fc/package.json

Line 34 in 00137e3

"types": "dist/esm/types/index.d.ts",

The types property above points to a declaration file which is not created. I would file a simple PR to change, but there are two extant D files, "index.d.ts" and "types.d.ts" and I am not sure which is preferable.
@texodus texodus added the bug Concrete, reproducible bugs label Nov 27, 2024
@timkpaine timkpaine changed the title d3fc package points to nonexistent "types" location d3fc/datagrid packages point to nonexistent "types" location Dec 1, 2024
@timkpaine timkpaine mentioned this issue Dec 1, 2024
Closed
@arslan-charyyev
Copy link

Would the maintainers be open to pull requests that fix this issue in a manner described in #2863 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Concrete, reproducible bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@texodus @brianblakely @arslan-charyyev