Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct edit-chroot option #933

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Use correct edit-chroot option #933

merged 2 commits into from
Dec 16, 2024

Conversation

nikic
Copy link
Collaborator

@nikic nikic commented Dec 15, 2024

According to copr edit-chroot --help, the name of the option is --repos, not --repo.

@nikic
Use correct edit-chroot option
46401eb 
According to `copr edit-chroot --help`, the name of the option
is `--repos`, not `--repo`.
@nikic nikic requested a review from kwk December 15, 2024 08:49
@nikic
Copy link
Collaborator Author

nikic commented Dec 15, 2024

Hm, I think this is not it. In a local test just --repo does work and it does successfully modify the chroot. Not sure why this doesn't work in snapshot builds then...

@nikic
Copy link
Collaborator Author

nikic commented Dec 15, 2024 •
edited
Loading

Ah, the reason that --repo works is that copr seems to generally accept prefixes of valid commands, so --repos, --repo and --rep etc all work. Doesn't explain what's going on with snapshots though.

@nikic
Use copr:// URL instead
601da25 
This works correctly on rawhide.
kwk
kwk approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@kwk kwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This should fix the problem of rawhide being translated to some version (currently 42) and it uses the much more condensed copr:// form. Thank you!

@nikic nikic merged commit 534975c into fedora-llvm-team:main Dec 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwk kwk kwk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikic @kwk