Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Simplify tests for websockets #13202

Merged
merged 1 commit into from
Jan 19, 2025
Merged

✅ Simplify tests for websockets #13202

merged 1 commit into from
Jan 19, 2025

Conversation

alejsdev
Copy link
Member

@alejsdev alejsdev commented Jan 12, 2025 •
edited
Loading

@alejsdev alejsdev marked this pull request as ready for review January 12, 2025 20:24
@alv2017
Copy link
Contributor

alv2017 commented Jan 16, 2025 •
edited
Loading

#11350

The actual reference is #13150 😊
(check other PRs as well)

tiangolo
tiangolo approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@tiangolo tiangolo merged commit 280fe73 into master Jan 19, 2025
30 checks passed
@tiangolo tiangolo deleted the tests-websockets branch January 19, 2025 22:40
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
@alejsdev @s-rigaud
✅ Simplify tests for websockets (fastapi#13202)
965e020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

@tiangolo tiangolo tiangolo approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alejsdev @alv2017 @tiangolo @svlandeg