chore: Add inputs to kurtosis-op workflow to override op-geth and op-node images [OPTION 2] #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjakubnanista
force-pushed
the
jan/workflow--002
branch
2 times, most recently
from
19afd66 to
a64f16e
Compare
janjakubnanista
force-pushed
the
jan/workflow--002
branch
from
a64f16e to
7f40425
Compare
emhane
reviewed
Jan 22, 2025
There was a problem hiding this comment.
if the op-reth image can be built from a local branch instead of being downloaded that would be better.
this is such a cool open-source contribution. for example @joshieDo sometimes has an op-node branch from his fork to test with op-reth. smthg interesting to upstream? or to odyssey maybe cc @onbjerg
janjakubnanista
force-pushed
the
jan/workflow--002
branch
from
7f40425 to
87b96ad
Compare
At the moment, all the images can be built off any git branch actually:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
op-nodeandop-gethimages inkurtosis-opoptimismandop-gethrepos, a fork can be specified as a source. The repos are cloned and the requestedrefis checked out dynamicallySince the repos are parametrized, one must be careful about them as they could potentially cause a security breach. Don't run this action with just any repo!
Fixes #14