Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:prompt-google-form examples added #248

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat:prompt-google-form examples added #248

wants to merge 3 commits into from

Conversation

adityavyas611
Copy link
Contributor

@adityavyas611 adityavyas611 commented Jan 8, 2020 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Examples have been added (for features GoogleFormPrompt)

What kind of change does this PR introduce?

  • In these Pull Request, I have added the examples for the google form prompt that I have extended from Form Prompt

What is the current behavior?

  • Created google form prompt from scratch using form prompt

What is the new behavior?

  • Added Google form prompt in the example section in the custom prompt which is generated from Form Prompt

Does this PR introduce a breaking change?

  • If the user wants to run the google form prompt then they need to download and import google-form-prompt from npm repository

Other information:

googlePrompt

@adityavyas611 adityavyas611 requested a review from doowb January 15, 2020 17:26
doowb
doowb requested changes Jan 17, 2020
View reviewed changes
Copy link
Member

@doowb doowb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The require statements for prompt-google-form are incorrect.

examples/googleform/enquirer.js Outdated Show resolved Hide resolved
examples/googleform/prompt.js Outdated Show resolved Hide resolved
examples/googleform/selectForm.js Outdated Show resolved Hide resolved
@adityavyas611 adityavyas611 requested a review from doowb January 17, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doowb doowb Awaiting requested review from doowb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adityavyas611 @doowb