fix(mail-merge): Keep column links state properly in sync nylas#2493

Summary: See https://phab.nylas.com/D3112 for full description - Update EditorAPI.insertCustomComponent to take a pre-generated anchorId Test Plan: Unit tests + manual Reviewers: bengotow, halla, jackie Reviewed By: jackie Differential Revision: https://phab.nylas.com/D3113
ellerbrock · Jul 22, 2016 · 7b02076 · 7b02076
1 parent 941708d
commit 7b02076
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/spec/components/table/table-data-source-spec.jsx b/spec/components/table/table-data-source-spec.jsx
@@ -69,14 +69,14 @@ describe('TableDataSource', function describeBlock() {
     });
   });
 
-  describe('removeColumn', () => {
+  describe('removeLastColumn', () => {
     it('removes last column from the data source\'s columns', () => {
-      const res = testDataSource.removeColumn()
+      const res = testDataSource.removeLastColumn()
       expect(res.columns()).toEqual(['col1', 'col2'])
     });
 
     it('removes last column from every row', () => {
-      const res = testDataSource.removeColumn()
+      const res = testDataSource.removeLastColumn()
       expect(res.rows()).toEqual([
         [1, 2],
         [4, 5],

diff --git a/src/components/contenteditable/editor-api.coffee b/src/components/contenteditable/editor-api.coffee
@@ -74,7 +74,7 @@ class EditorAPI
 
   insertCustomComponent: (componentKey, props = {}) ->
     OverlaidComponents ?= require('../overlaid-components/overlaid-components').default
-    {anchorId, anchorTag} = OverlaidComponents.buildAnchorTag(componentKey, props)
+    {anchorId, anchorTag} = OverlaidComponents.buildAnchorTag(componentKey, props, props.anchorId)
     @insertHTML(anchorTag)
     return anchorId
 

diff --git a/src/components/table/table-data-source.es6 b/src/components/table/table-data-source.es6
@@ -137,9 +137,9 @@ export default class TableDataSource {
    * Removes last column and all of its data.
    *
    * @return {TableDataSource} - updated data source instance
-   * @method removeColumn
+   * @method removeLastColumn
    */
-  removeColumn() {
+  removeLastColumn() {
     const nextRows = this.rows().map(row => row.slice(0, row.length - 1))
     const nextColumns = this.columns().slice(0, this.columns().length - 1)
     return new TableDataSource({

diff --git a/src/pro b/src/pro