-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: dynamic designformat registration #612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed to create report:
|
|
kareefardi
reviewed
Dec 15, 2024
kareefardi
reviewed
Dec 15, 2024
kareefardi
reviewed
Dec 15, 2024
kareefardi
reviewed
Dec 15, 2024
kareefardi
reviewed
Dec 15, 2024
kareefardi
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc Enhancements/Bugfixes
openlane.state
DesignFormat
.factory
is a factory for retrieval of DesignFormats by IDDesignFormats
may be registered to the factory using.register()
DesignFormat
s now moved to where appropriate.POWERED_NETLIST_NO_PHYSICAL_CELLS
toLOGICAL_POWERED_NETLIST
POWERED_NETLIST_SDF_FRIENDLY
toSDF_FRIENDLY_POWERED_NETLIST
State
None
now remove said keys.API Breaks
openlane.steps
TclStep
now uses the IDs uppercased forCURRENT_
andSAVE_
.openlane.state
State
no longer includes allDesignFormat
s as guaranteed keys and.get
must be used to avoideKeyErrors
DesignFormat
is no longer an enumeration and is not iterable. However, to avoid massive codebase changes, you can still accessDesignFormat
s registered to the factory using the dot notation (e.g.DesignFormat.NETLIST
), using either theirid
or any of theiralts
.DesignFormatObject
: the DesignFormat class itself is now a dataclass incorporating these fields, exceptname
, which has been renamed tofull_name
. The enumeration's name has been added toalts
, while.name
is now an alias for.id
.