Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VERILOG_INCLUDE_DIRS not being a Path disallows the use of dir:: #615

Closed
donn opened this issue Dec 4, 2024 · 0 comments · Fixed by #616
Closed

VERILOG_INCLUDE_DIRS not being a Path disallows the use of dir:: #615

donn opened this issue Dec 4, 2024 · 0 comments · Fixed by #616
Labels
🐞 bug Something isn't working

Comments

@donn
Copy link
Member

donn commented Dec 4, 2024

Description

Attempting to add VERILOG_INCLUDE_DIRS using dir:: results in a "refusing to automatically convert error."

Expected Behavior

It shouldn't be a conversion. It should be a path.

Environment report

kernel: Darwin
kernel_version: 24.1.0
supported: True
distro: macOS
distro_version: 15.1
python_version: 3.12.7
python_path:
  - /Users/donn/efabless/openlane2/main/openlane
  - /nix/store/dc1xxx6drgg44ly3jijmzky6cci4galn-python3-3.12.7/lib/python312.zip
  - /nix/store/dc1xxx6drgg44ly3jijmzky6cci4galn-python3-3.12.7/lib/python3.12
  - /nix/store/dc1xxx6drgg44ly3jijmzky6cci4galn-python3-3.12.7/lib/python3.12/lib-dynload
  - /nix/store/dc1xxx6drgg44ly3jijmzky6cci4galn-python3-3.12.7/lib/python3.12/site-packages
tkinter: True
container_info:
  engine: docker
  version: 27.3.1
  conmon: False
  rootless: False
nix_info:
  version_string: nix (Nix) 2.23.3
  channels:
  nix_command: True
  flakes: True

Reproduction material

echo '{"VERILOG_INCLUDE_DIRS": ["dir::."]}' >> ./openlane/examples/spm/vid.json
python3 -m openlane ./openlane/examples/spm/config.yaml ./openlane/examples/spm/vid.json

Relevant log output

[13:59:27] ERROR    Errors have occurred while loading the design configuration file.                                                                                                                  __main__.py:134
[13:59:27] ERROR    Refusing to automatically convert value at 'VERILOG_INCLUDE_DIRS[0]' to a string                                                                                                   __main__.py:136
[13:59:27] ERROR    OpenLane will now quit. Please check your configuration.
@donn donn added the 🐞 bug Something isn't working label Dec 4, 2024
@donn donn mentioned this issue Dec 4, 2024
Merged
@donn donn closed this as completed in #616 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: VERILOG_INCLUDE_DIRS not a list of Paths efabless/openlane2
1 participant
@donn