Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dropdowns): added support for floating-ui #2381

Open
wants to merge 1 commit into
base: 15.0.0
Choose a base branch
from
Open

feat(dropdowns): added support for floating-ui #2381

wants to merge 1 commit into from
+160 −29

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jan 15, 2025

Description

  • Added floating ui support for all dropdowns
  • Also added it for calendar
  • For combobox, need to retrigger the show attribute on makeup change in case the expander is expanded on rerender
  • For chips combobox there's an issue where we need to attach the dropdown to the root element. For this, passed in a function which resolves to the root elemenet into combobox. This attribute is not supposed to be documented outside of our code.
  • Reverse will be handled by the popper automatically

References

#2349

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: fdfef23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtBlue ArtBlue Awaiting requested review from ArtBlue

@HenriqueLimas HenriqueLimas Awaiting requested review from HenriqueLimas

@saiponnada saiponnada Awaiting requested review from saiponnada

@LuLaValva LuLaValva Awaiting requested review from LuLaValva

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@agliga