fix(dialog): added request animation frame before running keyboardTrap (

#2377)
eBay · Jan 10, 2025 · 06d6ae6 · 06d6ae6
1 parent 9500fd1
commit 06d6ae6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/good-jobs-cheat.md b/.changeset/good-jobs-cheat.md
@@ -0,0 +1,5 @@
+---
+"@ebay/ebayui-core": patch
+---
+
+fix(dialog): added request animation frame before running keyboardTrap
diff --git a/src/components/components/ebay-dialog-base/component.ts b/src/components/components/ebay-dialog-base/component.ts
@@ -246,7 +246,8 @@ class DialogBase extends Marko.Component<Input, State> {
             if (willTrap) {
                 screenReaderTrap.trap(this.el, { useHiddenProperty });
                 if (!useHiddenProperty) {
-                    keyboardTrap.trap(this.windowEl);
+                    // Adding request animation frame because focusables will return that all elements are not visible since dialog is still animating.
+                    requestAnimationFrame(() => keyboardTrap.trap(this.windowEl));
                 }
             }
         };