Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3488 TransferFunction from Dynawo, issue with REPCa #3493

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#3488 TransferFunction from Dynawo, issue with REPCa #3493

wants to merge 1 commit into from

Conversation

ErwanGuichard49
Copy link
Collaborator

Checklist before requesting a review

use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes

  • unit tests and non-regression tests were added (new model, new feature and bug fix)
  • main documentation was updated (update of input/output file, 3rd party, model, repository organization, solver)
  • example documentations were updated (new example in examples folder)
  • the corresponding milestone was added in the ticket and in this PR
  • if this PR modifies the parameters or inputs/outputs of a model/solver: the corresponding xsl was added in util/xsl and platform DB were updated
  • if this PR modifies a dictionary: the corresponding french dictionary was updated

@ErwanGuichard49 ErwanGuichard49 added Bug Something isn't working Models library labels Dec 2, 2024
@ErwanGuichard49 ErwanGuichard49 added this to the v1.7.0 milestone Dec 2, 2024
@ErwanGuichard49 ErwanGuichard49 mentioned this pull request Dec 2, 2024
Open
@ErwanGuichard49 ErwanGuichard49 linked an issue Dec 4, 2024 that may be closed by this pull request
Invalid access of x_scaled protected component #3488
Open
@ErwanGuichard49
Copy link
Collaborator Author

ErwanGuichard49 commented Dec 4, 2024 •
edited
Loading

Replacing the single if structure by two new ones in TransferFunction.mo allows the compilation to proceed.

@ErwanGuichard49
Copy link
Collaborator Author

ErwanGuichard49 commented Dec 4, 2024 •
edited
Loading

The output .csv files are longer with the TransferFunction block from Dynawo (either the new version or the current one) than with the block from the MSL.

The condition on a[1] = 0 (highest-order component of the denominator) causes the greater simulation time.

@ErwanGuichard49 ErwanGuichard49 marked this pull request as ready for review December 5, 2024 16:51
@ErwanGuichard49
Copy link
Collaborator Author

This PR :

  • removes the possibility of nx = 0 from TransferFunction (the block is never used with a denominator of order 0)
  • creates a parameter ZeroA1, meant to ignore (if the user chooses it) the possibility of a[1] = 0 (it thus simplifies the calculation)
  • substitutes the Dynawo block for the one from the Modelica Standard library (enabling its initialization under both Dynawo and OpenModelica, solving issue 3488)
  • adds to SlewRateLimiter blocks in GovCt2 and BaseREEC a modifier y(start = ...) (allowing the model to be correctly initialized under Dynawo)
  • updates nrt references and, in a few cases, solver parameters

@ErwanGuichard49 ErwanGuichard49 force-pushed the 3488_TransferFunction branch 3 times, most recently from 56efa4c to 794c876 Compare December 11, 2024 15:35
#3488 TransferFunction from Dynawo simplfied and systematically used …
85e62d3 
…(initialization), TransferFunctionBypass created for a few cases (a[1] = 0), nrt references updated

Signed-off-by: Erwan Guichard <erwan.guichard_externe@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyelfeghali joyelfeghali joyelfeghali requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Bug Something isn't working Models library
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Invalid access of x_scaled protected component
2 participants
@ErwanGuichard49 @joyelfeghali