#3396 handle properly complex init of variables in 06 file #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #3396 Signed-off-by: Florentine Rosiere <florentine.rosiere@rte-france.com>
gaouizer
reviewed
Sep 17, 2024
| @@ -1020,6 +1020,7 @@ def read_06inz_c_file(self): | |||
| # Find functions of type MODEL_NAME_eqFunction_N and variable assignment expressions | |||
| # Regular expression to recognize a line of type var = rhs | |||
| ptrn_assign_var = re.compile(r'^[ ]*data->localData(?P<var>\S*)[ ]*\/\* (?P<varName>[\w\$\.()\[\],]*) [\w(),\.]+ \*\/[ ]*=[ ]*(?P<rhs>[^;]+);') | |||
| ptrn_assign_var_complex = re.compile(r'^[ ]*data->modelData->(?P<var>\S*)\.attribute[ ]*\/\* (?P<varName>[ \w\$\.()\[\],]*) [\w(),\.\[\]]+ \*\/.start[ ]*=[^;]*;$') | |||
There was a problem hiding this comment.
I am not sure you are using the group name 'var' from this regex, am I correct?
| #data->localData[0]->realVars[...] = data->modelData->realVarsData[...].attribute.start; | ||
| if ptrn_assign_var_complex.search(line) is not None: | ||
| match = re.search(ptrn_assign_var_complex, line) | ||
| var = str(match.group('varName')) |
There was a problem hiding this comment.
The naming seems a bit confusing : the python variable named var is filled with the data extracted from the regex group named "varName" whereas in the same regex there is another group named "var" which seems to be unused. Is my understanding correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3396
Checklist before requesting a review
use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes