[COLIB-NGC] #3107 add govHydro4 #3393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyelfeghali
requested changes
Nov 12, 2024
dynawo/sources/Models/Modelica/Dynawo/Examples/SMIB/Standard/GovHydro4St4b2.mo
Outdated
Show resolved
Hide resolved
dynawo/sources/Models/Modelica/Dynawo/Examples/SMIB/Standard/GovHydro4St4b2.mo
Outdated
Show resolved
Hide resolved
...odels/Modelica/Dynawo/Electrical/Controls/Machines/Governors/Standard/Hydraulic/GovHydro4.mo
Outdated
Show resolved
Hide resolved
...odels/Modelica/Dynawo/Electrical/Controls/Machines/Governors/Standard/Hydraulic/GovHydro4.mo
Outdated
Show resolved
Hide resolved
...odels/Modelica/Dynawo/Electrical/Controls/Machines/Governors/Standard/Hydraulic/GovHydro4.mo
Outdated
Show resolved
Hide resolved
| Placement(visible = true, transformation(origin = {-40, 140}, extent = {{-10, -10}, {10, 10}}, rotation = 0))); | ||
| Modelica.Blocks.Continuous.LimIntegrator intLimG(outMax = GMax, outMin = GMin, y_start = InitSet) annotation( | ||
| Placement(visible = true, transformation(origin = {40, 140}, extent = {{-10, -10}, {10, 10}}, rotation = 0))); | ||
| Modelica.Blocks.Continuous.Integrator intTw(k = 1 / tW, y_start = Pm0Pu / ATurb + QNl) annotation( |
There was a problem hiding this comment.
Shouldn't be y_start = Pm0Pu / (ATurb*HDam) + QNl instead?
There was a problem hiding this comment.
@AGISTIN-Project Nils please answer
dynawo/sources/Models/Modelica/Dynawo/Examples/SMIB/Standard/GovHydro4St4b2.mo
Outdated
Show resolved
Hide resolved
...dels/Modelica/Dynawo/Electrical/Controls/Machines/Governors/Standard/Hydraulic/package.order
Show resolved
Hide resolved
...dels/Modelica/Dynawo/Electrical/Controls/Machines/Governors/Standard/Hydraulic/package.order
Show resolved
Hide resolved
dynawo/sources/Models/Modelica/Dynawo/Examples/SMIB/Standard/package.order
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin Franke <franke_martin@gmx.net> changed unit of one parameter correct unit for unintentional deadband deleted wrong limit in omega db fix type Signed-off-by: Martin Franke <franke_martin@gmx.net> fix elseif Signed-off-by: Martin Franke <franke_martin@gmx.net> fix param name Signed-off-by: Martin Franke <franke_martin@gmx.net> add review changes Signed-off-by: Martin Franke <franke_martin@gmx.net> fix Signed-off-by: Martin Franke <franke_martin@gmx.net>
martinscripts
force-pushed
the
3107_govHydro4
branch
from
f72af42 to
cbad117
Compare
|
Hey @joyelfeghali, I cared for most of the conversations (two are still open, one needs to be answered by nils) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes