bump version v0.19.5; added style compatibility with notebook v5.6.0

dunovank · Jul 31, 2018 · e1e0077 · e1e0077
1 parent fcaeac1
commit e1e0077
Show file tree

Hide file tree

Showing 17 changed files with 381 additions and 287 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,9 +1,11 @@
 ### Release Notes
 
+#### **v0.19.5**
+- added style compatibility with `notebook 5.6.0`
 
 #### **v0.19.4**
 - binder update
-- fixed prompt alignment across cell types 
+- fixed prompt alignment across cell types
 
 #### **v0.19.3**
 - only display run code-cell button on prompt hover

diff --git a/README.md b/README.md
@@ -50,10 +50,10 @@ pip install --upgrade jupyterthemes
 ```
 
 ### Known issues
+- **for best results:** use notebook>=5.6.0 (`pip install --upgrade notebook`)
 - **refreshing / removing / resetting:** depending on your system, browser, etc., you may need to empty your browser cache after installing a new theme (`-t`) or attempting to restore the default (`-r`) in order for those changes to take effect. (see discussion [here](https://github.com/dunovank/jupyter-themes/issues/86)). At the very least you'll need to refresh your browser window (usually `cmd+r` or `ctrl+r`).
 - **install issue:** if you get an error saying `jt` is not recognized, try [this](https://github.com/dunovank/jupyter-themes/issues/92#issuecomment-300688587) fix.
 - **slow render when scrolling:** fix available [here](https://github.com/dunovank/jupyter-themes/issues/117#issuecomment-296391443)
-- **for best results:** use notebook>=5.0 (`pip install --upgrade notebook`)
 
 
 ### Command Line Usage

diff --git a/jupyterthemes/__init__.py b/jupyterthemes/__init__.py
@@ -12,7 +12,7 @@
 
 major = 0
 minor = 19
-patch = 4
+patch = 5
 
 __version__ = '.'.join([str(v) for v in [major, minor, patch]])
 

diff --git a/jupyterthemes/layout/cells.less b/jupyterthemes/layout/cells.less
@@ -54,7 +54,7 @@ div.cell.selected:before,
 .edit_mode div.cell.selected:before,
 div.cell.selected:before,
 div.cell.selected.jupyter-soft-selected:before  {
-    background: @cc-input-bg;
+    background: @cc-input-bg !important;
     border: none;
     border-radius: 3px;
     position: absolute;
@@ -64,6 +64,16 @@ div.cell.selected.jupyter-soft-selected:before  {
     width: 0px;
     height: 100%;
 }
+
+div.cell.text_cell.selected::before,
+.edit_mode div.cell.text_cell.selected:before,
+div.cell.text_cell.selected:before,
+div.cell.text_cell.selected.jupyter-soft-selected:before {
+  background: @text-cell-bg !important;
+  background-color: @text-cell-bg !important;
+  border-color: @tc-border-selected !important;
+}
+
 div.cell.code_cell .input {
     border-left: 5px solid @cc-input-bg !important;
     border-radius: 3px;
@@ -418,7 +428,7 @@ div.cell.text_cell .prompt {
 }
 div.cell.text_cell.rendered .prompt {
     font-family: @monofont, monospace;
-    font-size: 9pt !important;
+    font-size: 9.5pt !important;
     font-weight: normal;
     color: @prompt-text !important;
     text-align: right !important;
@@ -431,7 +441,7 @@ div.cell.text_cell.rendered .prompt {
 }
 div.cell.text_cell.unrendered .prompt {
     font-family: @monofont, monospace;
-    font-size: 9pt !important;
+    font-size: 9.5pt !important;
     font-weight: normal;
     color: @prompt-text !important;
     text-align: right !important;
@@ -518,7 +528,7 @@ div.rendered_html pre {
     font-family: @monofont, monospace;
     font-size: @monofontsize !important;
     line-height: @cc-line-height !important;
-    color: @text-cell-fg;
+    color: @text-cell-fg !important;
     background: @codeblock-bg;
     background-color: @codeblock-bg;
     max-width: 80%;
@@ -574,36 +584,36 @@ div.rendered_html h5 {
 }
 .rendered_html h1,
 .text_cell_render h1 {
-    color: @header-fg;
+    color: @header-fg !important;
     font-size: 200%;
     text-align: left;
     font-style: normal;
     font-weight: normal;
 }
 .rendered_html h2,
 .text_cell_render h2 {
-    color: @header-fg;
+    color: @header-fg !important;
     font-size: 170%;
     font-style: normal;
     font-weight: normal;
 }
 .rendered_html h3,
 .text_cell_render h3 {
-    color: @header-fg;
+    color: @header-fg !important;
     font-size: 140%;
     font-style: normal;
     font-weight: normal;
 }
 .rendered_html h4,
 .text_cell_render h4 {
-    color: @header-fg;
+    color: @header-fg !important;
     font-size: 110%;
     font-style: normal;
     font-weight: normal;
 }
 .rendered_html h5,
 .text_cell_render h5 {
-    color: @header-fg;
+    color: @header-fg !important;
     font-size: 100%;
     font-style: normal;
     font-weight: normal;

diff --git a/jupyterthemes/layout/codemirror.less b/jupyterthemes/layout/codemirror.less
@@ -258,18 +258,18 @@ div.CodeMirror span.CodeMirror-nonmatchingbracket {
 div.cell.text_cell .cm-s-default .cm-header {
     font-family: @notebook-fontfamily;
     font-weight: normal;
-    color: @header-fg;
+    color: @header-fg !important;
     margin-top: 0.3em !important;
     margin-bottom: 0.3em !important;
 }
 div.cell.text_cell .cm-s-default span.cm-variable-2 {
-    color: @text-cell-fg;
+    color: @text-cell-fg !important;
 }
 div.cell.text_cell .cm-s-default span.cm-variable-3 {
-    color: @cm-variable3;
+    color: @cm-variable3 !important;
 }
 .cm-s-default span.cm-comment {
-    color: @cm-comment;
+    color: @cm-comment !important;
 }
 .cm-s-default .cm-tag {
     color: @cm-latex;

diff --git a/jupyterthemes/layout/notebook.less b/jupyterthemes/layout/notebook.less
@@ -534,9 +534,9 @@ p.navbar-text.indicator_area {
 }
 .navbar-default .navbar-nav > li > a:hover,
 .navbar-default .navbar-nav > li > a:focus {
-    color: @selected-fg;
-    background-color: @selected-third;
-    border-color: @dropdown-hover;
+    color: @selected-fg !important;
+    background-color: @selected-third !important;
+    border-color: @dropdown-hover !important;
     line-height: 1.5em;
     transition: 80ms ease;
 }
@@ -694,6 +694,7 @@ div#notification_notebook.notification_widget.btn.btn-xs.navbar-btn {
     padding-bottom: 4px;
     margin-top: 8px !important;
     margin-left: -2px;
+    padding-left: 5px !important;
 }
 #kernel_indicator .kernel_indicator_name {
     font-size: 17px;
@@ -703,7 +704,7 @@ div#notification_notebook.notification_widget.btn.btn-xs.navbar-btn {
     padding-left: 5px;
     padding-right: 5px;
     margin-top: 4px;
-    vertical-align: -webkit-baseline-middle;
+    vertical-align: text-top;
     padding-bottom: 0px;
 }
 

diff --git a/jupyterthemes/stylefx.py b/jupyterthemes/stylefx.py
@@ -255,9 +255,9 @@ def style_layout(style_less,
     promptPadding = '.25em'
     promptBorder = '2px solid @prompt-line'
     tcPromptBorder = '2px solid @tc-prompt-std'
-    promptMinWidth = 13.5
-    outpromptMinWidth = promptMinWidth
-    tcPromptWidth = promptMinWidth + 1
+    promptMinWidth = 11.5
+    outpromptMinWidth = promptMinWidth + 3
+    tcPromptWidth = promptMinWidth + 3
     tcPromptFontsize = "@prompt-fontsize"
     ccOutputBG = '@cc-output-bg-default'
 
@@ -266,8 +266,8 @@ def style_layout(style_less,
     if altprompt:
         promptPadding = '.1em'
         promptMinWidth = 8
-        outpromptMinWidth = promptMinWidth + 2
-        tcPromptWidth = 11
+        outpromptMinWidth = promptMinWidth + 3
+        tcPromptWidth = promptMinWidth + 3
         promptText = 'transparent'
         tcPromptBorder = '2px solid transparent'
     if altmd: