Fix issues parsing Int and Float (r0adkll#145)

Undefined was transformed into NaN, which is not undefined and thus failed validation
dogi · Sep 24, 2022 · 99b7a1e · 99b7a1e
1 parent 7cd1379
commit 99b7a1e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/lib/index.js b/lib/index.js
diff --git a/src/edits.ts b/src/edits.ts
@@ -24,7 +24,7 @@ export interface EditOptions {
     applicationId: string;
     track: string;
     inAppUpdatePriority: number;
-    userFraction: number;
+    userFraction?: number;
     whatsNewDir?: string;
     mappingFile?: string;
     debugSymbols?: string;

diff --git a/src/main.ts b/src/main.ts
@@ -33,14 +33,24 @@ async function run() {
         await validateServiceAccountJson(serviceAccountJsonRaw, serviceAccountJson)
 
         // Validate user fraction
-        const userFractionFloat = parseFloat(userFraction)
+        let userFractionFloat: number | undefined
+        if (userFraction) {
+            userFractionFloat = parseFloat(userFraction)
+        } else {
+            userFractionFloat = undefined
+        }
         await validateUserFraction(userFractionFloat)
 
         // Validate release status
         await validateStatus(status, userFraction != undefined)
 
         // Validate the inAppUpdatePriority to be a valid number in within [0, 5]
-        const inAppUpdatePriorityInt: number | undefined = parseInt(inAppUpdatePriority);
+        let inAppUpdatePriorityInt: number | undefined
+        if (inAppUpdatePriority) {
+            inAppUpdatePriorityInt = parseInt(inAppUpdatePriority)
+        } else {
+            inAppUpdatePriorityInt = undefined
+        }
         await validateInAppUpdatePriority(inAppUpdatePriorityInt)
 
         // Check release files while maintaining backward compatibility