Merge pull request williamngan#62 from tibotiber/fix/extra-drop

Fix/extra drop
doc22940 · May 27, 2019 · aaae365 · aaae365
2 parents 7643c01 + d02fa91
commit aaae365
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 5 deletions.
diff --git a/dist/es2015/UI.js b/dist/es2015/UI.js
diff --git a/dist/es5.js b/dist/es5.js
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/pts.js b/dist/pts.js
diff --git a/src/UI.ts b/src/UI.ts
@@ -420,6 +420,7 @@ export class UIDragger extends UIButton {
   constructor( group:GroupLike, shape:string, states:{[key:string]: any}={}, id?:string ) {
     super( group, shape, states, id );
     if (states.dragging === undefined) this._states['dragging'] = false;
+    if (states.moved === undefined) this._states['moved'] = false;
     if (states.offset === undefined) this._states['offset'] = new Pt();
 
     const UA = UIPointerActions;
@@ -434,6 +435,7 @@ export class UIDragger extends UIButton {
       this._draggingID = this.on( UA.move, (t:UI, p:PtLike) => {
         if ( this.state('dragging') ) {
           UI._trigger( this._actions[UA.uidrag], t, p, UA.uidrag );
+          this.state( 'moved', true );
         }
       });
     });
@@ -443,7 +445,10 @@ export class UIDragger extends UIButton {
       this.state('dragging', false);
       this.off(UA.move, this._draggingID); // remove 'all' listener
       this.unhold( this._moveHoldID ); // // stop keeping hold of move
-      UI._trigger( this._actions[UA.drop], target, pt, type );
+      if ( this.state('moved') ) {
+        UI._trigger( this._actions[UA.drop], target, pt, type );
+        this.state( 'moved', false );
+      }
     });
 
   }