Support favicon work on Safari (#22398) #24033
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SP12893678
force-pushed
the
fix/#22398-favicon-Safari
branch
from
7c1f1fc to
35ef24f
Compare
rijkvanzanten
requested changes
Nov 27, 2024
Comment on lines
+21
to
+23
| const resvg = new Resvg(svg(color, addDirectusLogo)); | ||
| const buffer = resvg.render().asPng(); | ||
| return buffer; |
There was a problem hiding this comment.
Little worried we're rendering out a png from the SVG everytime the favicon is requested. I haven't done the perf testing yet, but isn't that a fairly heavy thing to do every time? Wondering if we should have some caching for this, or if there's a world where we return the SVG favicon for browsers that support svg favicons and have a default png that doesn't have to be generated each time as a fallback for browsers that don't 🤔
There was a problem hiding this comment.
Yep, using caching can definitely reduce the performance overhead.
In additional, I will try detecting browser support via user agent to conditional handle it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Support favicon work on Safari
What's changed:
Tips
2024-11-12.11.45.36.1.mp4
Potential Risks / Drawbacks
Review Notes / Questions
Fixes #22398