Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std string #8048

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Use std string #8048

merged 2 commits into from
Jan 8, 2025

Conversation

@sithlord48 sithlord48 force-pushed the useStdString branch 2 times, most recently from 1bdf620 to c734fd6 Compare January 6, 2025 05:22
@sithlord48 sithlord48 requested a review from nbolton January 6, 2025 05:35
@sithlord48 sithlord48 force-pushed the useStdString branch 3 times, most recently from 43e5760 to 136bc04 Compare January 6, 2025 06:34
@sithlord48 sithlord48 marked this pull request as draft January 6, 2025 06:35
@sithlord48 sithlord48 self-assigned this Jan 6, 2025
@sithlord48 sithlord48 force-pushed the useStdString branch 6 times, most recently from 74d319d to 7f06e90 Compare January 7, 2025 23:48
@sithlord48 sithlord48 marked this pull request as ready for review January 7, 2025 23:48
Copy link
Member

@nbolton nbolton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this. Way overdue.

@nbolton nbolton merged commit 6c95daf into master Jan 8, 2025
22 checks passed
@nbolton nbolton deleted the useStdString branch January 8, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants