BREAKING(testing/asserts): remove implicit any types from assert sign…

…atures. (#2203)
denoland · May 20, 2022 · 11b2b7f · 11b2b7f
1 parent ce671db
commit 11b2b7f
Showing 9 changed files with 117 additions and 154 deletions.
diff --git a/archive/tar_test.ts b/archive/tar_test.ts
@@ -13,6 +13,7 @@ import { assert, assertEquals } from "../testing/asserts.ts";
 
 import { dirname, fromFileUrl, resolve } from "../path/mod.ts";
 import { Tar, Untar } from "./tar.ts";
+import type { TarMeta } from "./tar.ts";
 import { Buffer } from "../io/buffer.ts";
 import { copy, readAll } from "../streams/conversion.ts";
 
@@ -317,7 +318,9 @@ Deno.test("untarLinuxGeneratedTar", async function () {
   const filePath = resolve(testdataDir, "deno.tar");
   const file = await Deno.open(filePath, { read: true });
 
-  const expectedEntries = [
+  type ExpectedEntry = TarMeta & { content?: Uint8Array };
+
+  const expectedEntries: ExpectedEntry[] = [
     {
       fileName: "archive/",
       fileSize: 0,

diff --git a/collections/deep_merge_test.ts b/collections/deep_merge_test.ts
@@ -95,7 +95,7 @@ Deno.test("deepMerge: prevent calling Object.prototype.__proto__ accessor proper
     configurable: true,
   });
   try {
-    assertEquals(
+    assertEquals<unknown>(
       deepMerge({
         foo: true,
       }, {

diff --git a/collections/first_not_nullish_of_test.ts b/collections/first_not_nullish_of_test.ts
@@ -5,7 +5,7 @@ import { firstNotNullishOf } from "./first_not_nullish_of.ts";
 
 function firstNotNullishOfTest<T, O>(
   input: [Array<T>, (el: T) => O | undefined | null],
-  expected: O,
+  expected: NonNullable<O> | undefined,
   message?: string,
 ) {
   const actual = firstNotNullishOf(...input);

diff --git a/encoding/_toml/parser_test.ts b/encoding/_toml/parser_test.ts
@@ -359,7 +359,7 @@ Deno.test({
                 email: {
                   x: { main: "mail@example.com" },
                 },
-              },
+              } as unknown,
             },
           ],
         },

diff --git a/encoding/jsonc_test.ts b/encoding/jsonc_test.ts
@@ -120,7 +120,7 @@ Deno.test({
     const json = JSON.parse('{"__proto__": 100}');
     const jsonc = JSONC.parse('{"__proto__": 100}');
     assertEquals(jsonc, json);
-    assertEquals((jsonc as Record<string, string>).__proto__, 100);
+    assertEquals((jsonc as Record<string, number>).__proto__, 100);
     assertEquals((jsonc as Record<string, string>).__proto__, json.__proto__);
     assertStrictEquals(Object.getPrototypeOf(jsonc), Object.prototype);
     assertStrictEquals(