Enable warn_unreachable for twisted.python.test.test_inotify

debugmm · Sep 25, 2020 · e85e81e · e85e81e
1 parent c3e3f6a
commit e85e81e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/mypy.ini b/mypy.ini
@@ -265,9 +265,6 @@ warn_unreachable = False
 [mypy-twisted.persisted.sob]
 warn_unreachable = False
 
-[mypy-twisted.python.test.test_inotify]
-warn_unreachable = False
-
 [mypy-twisted.web.http_headers]
 warn_unreachable = False
 

diff --git a/src/twisted/python/test/test_inotify.py b/src/twisted/python/test/test_inotify.py
@@ -9,20 +9,26 @@
 from twisted.python.filepath import FilePath
 from twisted.python.runtime import platform
 
-if platform.supportsINotify():
-    from ctypes import c_int, c_uint32, c_char_p
+try:
     from twisted.python import _inotify
+except ImportError:
+    inotify = None
+else:
+    inotify = _inotify
+
+if inotify and platform.supportsINotify():
+    from ctypes import c_int, c_uint32, c_char_p
     from twisted.python._inotify import INotifyError, initializeModule, init, add
 else:
-    _inotify = None  # type: ignore[assignment]
+    inotify = None
 
 
 class INotifyTests(TestCase):
     """
     Tests for L{twisted.python._inotify}.
     """
 
-    if _inotify is None:
+    if inotify is None:
         skip = "This platform doesn't support INotify."
 
     def test_missingInit(self):
@@ -114,7 +120,7 @@ class libc:
             def inotify_init(self):
                 return -1
 
-        self.patch(_inotify, "libc", libc())
+        self.patch(inotify, "libc", libc())
         self.assertRaises(INotifyError, init)
 
     def test_failedAddWatch(self):
@@ -127,5 +133,5 @@ class libc:
             def inotify_add_watch(self, fd, path, mask):
                 return -1
 
-        self.patch(_inotify, "libc", libc())
+        self.patch(inotify, "libc", libc())
         self.assertRaises(INotifyError, add, 3, FilePath("/foo"), 0)