Enable warn_unreachable for remaining files in twisted.internet.

debugmm · Sep 25, 2020 · 6ebbae7 · 6ebbae7
1 parent c3e3f6a
commit 6ebbae7
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 16 deletions.
diff --git a/mypy.ini b/mypy.ini
@@ -253,12 +253,6 @@ warn_unreachable = False
 [mypy-twisted.conch.test.test_ssh]
 warn_unreachable = False
 
-[mypy-twisted.internet.defer]
-warn_unreachable = False
-
-[mypy-twisted.internet.test.test_endpoints]
-warn_unreachable = False
-
 [mypy-twisted.persisted.aot]
 warn_unreachable = False
 

diff --git a/src/twisted/internet/defer.py b/src/twisted/internet/defer.py
@@ -17,19 +17,21 @@
 """
 
 
-import attr
+from asyncio import iscoroutine
+from functools import wraps
+from sys import exc_info, version_info
 import traceback
 import types
+from typing import Optional
 import warnings
-from asyncio import iscoroutine
-from sys import exc_info, version_info
-from functools import wraps
+
+import attr
 from incremental import Version
 
 # Twisted imports
-from twisted.python.compat import cmp, comparable
-from twisted.python import lockfile, failure
 from twisted.logger import Logger
+from twisted.python import lockfile, failure
+from twisted.python.compat import cmp, comparable
 from twisted.python.deprecate import warnAboutFunction, deprecated
 
 try:
@@ -264,7 +266,7 @@ class Deferred:
     # sets it directly.
     debug = False
 
-    _chainedTo = None
+    _chainedTo = None  # type: Optional[Deferred]
 
     def __init__(self, canceller=None):
         """

diff --git a/src/twisted/internet/test/test_endpoints.py b/src/twisted/internet/test/test_endpoints.py
@@ -1324,7 +1324,7 @@ def createServerEndpoint(self, reactor, factory, **listenArgs):
         address = IPv4Address("TCP", "0.0.0.0", 0)
 
         if listenArgs is None:
-            listenArgs = {}
+            listenArgs = {}  # type: ignore[unreachable]
 
         return (
             endpoints.TCP4ServerEndpoint(reactor, address.port, **listenArgs),
@@ -1439,7 +1439,7 @@ def createServerEndpoint(self, reactor, factory, **listenArgs):
         address = IPv6Address("TCP", interface, 0)
 
         if listenArgs is None:
-            listenArgs = {}
+            listenArgs = {}  # type: ignore[unreachable]
 
         return (
             endpoints.TCP6ServerEndpoint(reactor, address.port, **listenArgs),
@@ -2812,7 +2812,7 @@ def createClientEndpoint(self, reactor, clientFactory, **connectArgs):
         address = IPv4Address("TCP", "localhost", 80)
 
         if connectArgs is None:
-            connectArgs = {}
+            connectArgs = {}  # type: ignore[unreachable]
 
         return (
             endpoints.SSL4ClientEndpoint(