Add type hints to twisted.internet.defer

debugmm · Oct 14, 2020 · 2543e2f · 2543e2f
1 parent 7359931
commit 2543e2f
Show file tree

Hide file tree

Showing 4 changed files with 419 additions and 312 deletions.
diff --git a/mypy.ini b/mypy.ini
@@ -149,10 +149,6 @@ check_untyped_defs = False
 allow_untyped_defs = True
 check_untyped_defs = False
 
-[mypy-twisted.internet.defer]
-allow_untyped_defs = True
-check_untyped_defs = False
-
 [mypy-twisted.internet.endpoints]
 allow_untyped_defs = True
 check_untyped_defs = False

diff --git a/src/twisted/internet/base.py b/src/twisted/internet/base.py
@@ -487,7 +487,7 @@ def fireEvent(self) -> None:
         """
         self.state = "BEFORE"
         self.finishedBefore = []
-        beforeResults = []  # type: List[object]
+        beforeResults = []  # type: List[Deferred]
         while self.before:
             callable, args, kwargs = self.before.pop(0)
             self.finishedBefore.append((callable, args, kwargs))