Merge pull request twisted#1627 from graingert/fix-idna-type-annotation

10229 type annotate twisted.internet._idna to fix CI
dctikan · Jul 15, 2021 · 8e7255e · 8e7255e
2 parents ba5cae9 + 2df3da1
commit 8e7255e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/mypy.ini b/mypy.ini
@@ -82,10 +82,6 @@ check_untyped_defs = False
 allow_untyped_defs = True
 check_untyped_defs = False
 
-[mypy-twisted.internet._idna]
-allow_untyped_defs = True
-check_untyped_defs = False
-
 [mypy-twisted.internet._newtls]
 allow_untyped_defs = True
 check_untyped_defs = False

diff --git a/src/twisted/internet/_idna.py b/src/twisted/internet/_idna.py
@@ -8,7 +8,7 @@
 """
 
 
-def _idnaBytes(text):
+def _idnaBytes(text: str) -> bytes:
     """
     Convert some text typed by a human into some ASCII bytes.
 
@@ -24,14 +24,14 @@ def _idnaBytes(text):
     @rtype: L{bytes}
     """
     try:
-        import idna  # type: ignore[import]
+        import idna
     except ImportError:
         return text.encode("idna")
     else:
         return idna.encode(text)
 
 
-def _idnaText(octets):
+def _idnaText(octets: bytes) -> str:
     """
     Convert some IDNA-encoded octets into some human-readable text.
 

diff --git a/src/twisted/newsfragments/10229.misc b/src/twisted/newsfragments/10229.misc